X-Git-Url: https://diplodocus.org/git/flac-archive/blobdiff_plain/10d83bbfbcd2461f4fd53f6bc17d1250922214b5..e53e2434445e78d18c0bdf3596b1444ddb399bde:/fa-encode

diff --git a/fa-encode b/fa-encode
index c18b1bc..a4db1b6 100755
--- a/fa-encode
+++ b/fa-encode
@@ -27,8 +27,14 @@ TODO:  implement B<-d>
 # - TRACKNUMBER - The track number of this piece
 # - ARTIST - The artist generally considered responsible for the track
 # - DATE - Date the track was recorded (XXX I use US release date)
-# I use one more, though I'm unsure where I got it.  Did I make it up?
-# - DISCNUMBER - number in multi-disc collection
+# https://age.hobba.nl/audio/mirroredpages/ogg-tagging.html (supposedly mirrored from http://reactor-core.org/ogg-tagging.html )
+# specifies more:
+# - DISCNUMBER - if part of a multi-disc album, put the disc number here
+# - VERSION - e.g. "live", "radio edit"
+# - PARTNUMBER - part number if a work is divided across tracks
+# - PART - part name e.g. "Oh sole mio"
+# https://picard-docs.musicbrainz.org/en/appendices/tag_mapping.html
+# - ALBUMARTIST - maps to ID3v2 TPE2
 
 # Input is a directory containing:
 # - trackNN.cdda.wav - WAV  format files ripped from CD-DA audio tracks where NN is track number 01 - 99
@@ -133,7 +139,7 @@ sub main {
                       ),
             );
         -e $fn && die("cowardly refusing to clobber $fn");
-        my @pictures = ('--picture', quote('3|image/jpeg|||cover.front')); # TODO optional
+        my @pictures = ('--picture', quote('3|image/jpeg|||cover.front.jpeg')); # TODO optional
         say(join(' ',
                  'flac -o',
                  quote($fn),
@@ -151,7 +157,7 @@ sub main {
                  "track$tracknum_s.cdda.wav"
             ));
     }
-    say('rm tags cover.front');
+    say('rm tags cover.front.jpeg');
 
     return 0;
 }
@@ -161,4 +167,3 @@ if (!caller) {
 }
 
 1;
-