X-Git-Url: https://diplodocus.org/git/flac-archive/blobdiff_plain/d846179a20f22c9f85688ac6929026c98669c8d5..d68e39caa6c9d64fa0d284faf71aa32d0fdc0fa6:/flac2mp3 diff --git a/flac2mp3 b/flac2mp3 index b105b96..d9f9f7b 100755 --- a/flac2mp3 +++ b/flac2mp3 @@ -67,7 +67,7 @@ from flac_archive.tags import Tags ################################################################################ # The child processes -def flac2mp3(fn, title, artist, album_artist, album, date, +def flac2mp3(fn, title, artist, album_artist, album, discnum, date, track, skip_until, pics=None): (title, artist, album) = [(x == None and 'unknown') or x for x in (title, artist, album)] @@ -89,9 +89,6 @@ def flac2mp3(fn, title, artist, album_artist, album, date, verbose and tmp.append('--verbose') lame_options = ' '.join(tmp) - outfile = ('%s (%s) %02d %s.mp3' % (artist, album, - track, title)).replace('/', '_') - # Escape any single quotes ' so we can quote this. (fn, title, artist, album_artist, album, date) = [(x or '').replace("'", r"'\''") @@ -101,7 +98,13 @@ def flac2mp3(fn, title, artist, album_artist, album, date, if album_artist: album_artist_options = "--tv 'TPE2=%s'" % album_artist - quoted_outfile = ('%s (%s) %02d %s.mp3' % (artist, album, + outfile_album = album + discnum_options = '' + if discnum != None: + outfile_album = '%s (disc %s)' % (album, discnum) + discnum_options = "--tv 'TPOS=%d'" % int(discnum) + + quoted_outfile = ('%s (%s) %02d %s.mp3' % (artist, outfile_album, track, title)).replace('/', '_') pic_options = None @@ -112,10 +115,11 @@ def flac2mp3(fn, title, artist, album_artist, album, date, f.close() pic_options = "--ti '%s'" % picfn try: - run_or_die(3, "flac %s -cd %s '%s' | lame --id3v2-only --id3v2-latin1 --pad-id3v2-size 0 %s --tt '%s' --ta '%s' --tl '%s' --ty '%s' --tn %d %s %s - '%s'" + run_or_die(3, "flac %s -cd %s '%s' | lame --id3v2-only --id3v2-latin1 --pad-id3v2-size 0 %s --tt '%s' --ta '%s' --tl '%s' --ty '%s' --tn %d %s %s %s - '%s'" % (flac_options, ' '.join(skip_until), fn, lame_options, title, artist, album, date, track, - pic_options, album_artist_options, quoted_outfile)) + pic_options, album_artist_options, + discnum_options, quoted_outfile)) finally: if pic_options: try: @@ -225,10 +229,6 @@ def main(argv): discnum = tags.gets('DISCNUMBER') track = tags.gets('TRACKNUMBER') - # lame doesn't seem to support disc number. - if discnum != None: - album = '%s (disc %s)' % (album, discnum) - # Stupid hack: only a single-track file should have the # TRACKNUMBER tag, so use it if set for the first pass through # the loop. At the end of the loop, we'll set $track for the @@ -251,11 +251,11 @@ def main(argv): artist = tags.get('ARTIST', track) artist.extend(tags.get('FEATURING', track)) album_artist = tags.gets('ALBUMARTIST', track) - jobs.append([fn, title, + jobs.append((fn, title, ', '.join(artist), - album_artist, album, + album_artist, album, discnum, tags.gets('DATE', track), - track, args[i], pics]) + track, args[i], pics)) track = i + 2 except Exception, error: sys.stderr.write(getattr(error, 'msg', ''))