X-Git-Url: https://diplodocus.org/git/flac-archive/blobdiff_plain/deb692c6d99f8d4bc99ccc46975f9b91ded6f596..1de330a82414d0c2013e614a04356ebfcfe22dec:/flac2mp3 diff --git a/flac2mp3 b/flac2mp3 index 5a92c3c..73df9b6 100755 --- a/flac2mp3 +++ b/flac2mp3 @@ -106,15 +106,18 @@ sub flac2mp3 { my $track = shift; my $skip_arg = shift; my $until_arg = shift; + my $outfile; - my $outfile = sprintf("$artist ($album) \%02s $title.mp3", $track); - for ($outfile) { - s/\//_/g; - s/:/_/g; - s/'/_/g; - s/"/_/g; + # We'll be putting these in single quotes, so we need to escape + # any single quotes in the filename by closing the quote ('), + # putting an escaped quote (\'), and then reopening the quote ('). + for ($fn, $title, $artist, $album, $date) { + s/'/'\\''/; } + $outfile = sprintf("$artist ($album) \%02s $title.mp3", $track); + $outfile =~ s/\//_/g; + $until_arg ||= ''; # XXX system("flac -cd $skip_arg $until_arg '$fn' | lame --preset standard --tt '$title' --ta '$artist' --tl '$album' --ty '$date' --tn $track - '$outfile'");