From:  <epg@pretzelnet.org>
Date: Sun, 8 Dec 2013 23:19:20 +0000 (-0800)
Subject: some cleanup
X-Git-Url: https://diplodocus.org/git/flac-archive/commitdiff_plain/3e5ac1b35b5e96d2e2e0570f163493fca75a00e3?hp=926e2a6a49a8146a95096e3c8c13451fdaaed860

some cleanup
---

diff --git a/apic-read.cc b/apic-read.cc
index fd83ac8..194e340 100644
--- a/apic-read.cc
+++ b/apic-read.cc
@@ -12,19 +12,22 @@
 
 // some demo apic reading code; would be nice to save all APIC frames.
 
+using TagLib::ID3v2::Tag;
+using TagLib::ID3v2::FrameList;
+using TagLib::ID3v2::AttachedPictureFrame;
+
 int
 main(int argc, char **argv)
 {
     const char *mp3_path = argv[1];
     TagLib::MPEG::File f(mp3_path);
-    TagLib::ID3v2::Tag *id3v2tag = f.ID3v2Tag();
+    Tag *id3v2tag = f.ID3v2Tag();
     if (!id3v2tag) {
         return 0;
     }
-    TagLib::ID3v2::FrameList::ConstIterator it;
-    for (it = id3v2tag->frameList().begin();
-         it != id3v2tag->frameList().end();
-         it++) {
+    const FrameList &frames = id3v2tag->frameList();
+    FrameList::ConstIterator it;
+    for (it = frames.begin(); it != frames.end(); it++) {
         TagLib::ByteVector frameid = (*it)->frameID();
         uint frameid_size = frameid.size();
         char *frameid_s = new char[frameid_size + 1];
@@ -34,8 +37,7 @@ main(int argc, char **argv)
         if (frameid != "APIC") {
             continue;
         }
-        TagLib::ID3v2::AttachedPictureFrame *frame =
-            (TagLib::ID3v2::AttachedPictureFrame *)(*it);
+        AttachedPictureFrame *frame = (AttachedPictureFrame *)(*it);
         TagLib::ByteVector data = frame->picture();
         int fd = open(argv[2], O_CREAT | O_WRONLY);
         ssize_t size = data.size();