From:  <epg@pretzelnet.org>
Date: Mon, 21 Jan 2013 00:20:03 +0000 (-0800)
Subject: Use TPOS to store discnumber in mp3 files.
X-Git-Url: https://diplodocus.org/git/flac-archive/commitdiff_plain/ab7bc57e5eee62b66b5386630c584b05efb361d5

Use TPOS to store discnumber in mp3 files.
---

diff --git a/flac2mp3 b/flac2mp3
index b105b96..cbc0662 100755
--- a/flac2mp3
+++ b/flac2mp3
@@ -67,7 +67,7 @@ from flac_archive.tags import Tags
 ################################################################################
 # The child processes
 
-def flac2mp3(fn, title, artist, album_artist, album, date,
+def flac2mp3(fn, title, artist, album_artist, album, discnum, date,
              track, skip_until, pics=None):
     (title, artist, album) = [(x == None and 'unknown') or x
                               for x in (title, artist, album)]
@@ -101,7 +101,13 @@ def flac2mp3(fn, title, artist, album_artist, album, date,
     if album_artist:
         album_artist_options = "--tv 'TPE2=%s'" % album_artist
 
-    quoted_outfile = ('%s (%s) %02d %s.mp3' % (artist, album,
+    outfile_album = album
+    discnum_options = ''
+    if discnum != None:
+        outfile_album = '%s (disc %s)' % (album, discnum)
+        discnum_options = "--tv 'TPOS=%d'" % int(discnum)
+
+    quoted_outfile = ('%s (%s) %02d %s.mp3' % (artist, outfile_album,
                                                track, title)).replace('/', '_')
 
     pic_options = None
@@ -112,10 +118,11 @@ def flac2mp3(fn, title, artist, album_artist, album, date,
         f.close()
         pic_options = "--ti '%s'" % picfn
     try:
-        run_or_die(3, "flac %s -cd %s '%s' | lame --id3v2-only --id3v2-latin1 --pad-id3v2-size 0 %s --tt '%s' --ta '%s' --tl '%s' --ty '%s' --tn %d %s %s - '%s'"
+        run_or_die(3, "flac %s -cd %s '%s' | lame --id3v2-only --id3v2-latin1 --pad-id3v2-size 0 %s --tt '%s' --ta '%s' --tl '%s' --ty '%s' --tn %d %s %s %s - '%s'"
                    % (flac_options, ' '.join(skip_until), fn,
                       lame_options, title, artist, album, date, track,
-                      pic_options, album_artist_options, quoted_outfile))
+                      pic_options, album_artist_options,
+                      discnum_options, quoted_outfile))
     finally:
         if pic_options:
             try:
@@ -225,10 +232,6 @@ def main(argv):
                 discnum = tags.gets('DISCNUMBER')
                 track = tags.gets('TRACKNUMBER')
 
-                # lame doesn't seem to support disc number.
-                if discnum != None:
-                    album = '%s (disc %s)' % (album, discnum)
-
                 # Stupid hack: only a single-track file should have the
                 # TRACKNUMBER tag, so use it if set for the first pass through
                 # the loop.  At the end of the loop, we'll set $track for the
@@ -251,11 +254,11 @@ def main(argv):
                     artist = tags.get('ARTIST', track)
                     artist.extend(tags.get('FEATURING', track))
                     album_artist = tags.gets('ALBUMARTIST', track)
-                    jobs.append([fn, title,
+                    jobs.append((fn, title,
                                  ', '.join(artist),
-                                 album_artist, album,
+                                 album_artist, album, discnum,
                                  tags.gets('DATE', track),
-                                 track, args[i], pics])
+                                 track, args[i], pics))
                     track = i + 2
             except Exception, error:
                 sys.stderr.write(getattr(error, 'msg', ''))