From 050e4e9a8ad2e021c40ee33a0af475a614672482 Mon Sep 17 00:00:00 2001 From: Date: Sun, 8 Dec 2013 17:15:52 -0800 Subject: [PATCH] todo --- flac2mp3 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/flac2mp3 b/flac2mp3 index 239739e..b7a5a21 100755 --- a/flac2mp3 +++ b/flac2mp3 @@ -112,7 +112,7 @@ def flac2mp3(fn, title, artist, album_artist, album, discnum, date, pic_options = '' (fd, picfn) = tempfile.mkstemp() os.close(fd) - p = Popen(['metaflac', '--export-picture-to=' + picfn, fn], stderr=PIPE) + p = Popen(['metaflac', '--export-picture-to', picfn, fn], stderr=PIPE) status = p.wait() stderr = ''.join(p.stderr) # Hacky check for flac with no album art @@ -126,6 +126,7 @@ def flac2mp3(fn, title, artist, album_artist, album, discnum, date, pic_options = "--ti '%s'" % picfn os.system('md5sum ' + picfn) try: + # TODO: Look at TDOR, TDRL, TDRC for date. run_or_die(3, "flac %s -cd %s '%s' | lame --id3v2-only --id3v2-latin1 --pad-id3v2-size 0 %s --tt '%s' --ta '%s' --tl '%s' --ty '%s' --tn %d %s %s %s - '%s'" % (flac_options, ' '.join(skip_until), fn, lame_options, title, artist, album, date, track, -- 2.56.0