Editing of man/pick.man.

[nmh] / uip / pick.c

diff --git a/uip/pick.c b/uip/pick.c
index fba190a250abb35b124ae582ce37f2f21ec61556..801716fe3cb35934724360608ee6dfad36268d4a 100644 (file)
--- a/uip/pick.c
+++ b/uip/pick.c
@@ -66,9 +66,10 @@ main (int argc, char **argv)
     struct msgs_array msgs = { 0, 0, NULL };
     struct msgnum_array nums = { 0, 0, NULL };
     struct msgs *mp, *mp2;
-    register FILE *fp;
+    FILE *fp;
     int debug = 0;
     int reverse = 0;
+    int start, end, inc;
 
     if (nmh_init(argv[0], 1)) { return 1; }
 
@@ -237,15 +238,22 @@ main (int argc, char **argv)
      * match.  If there is NOT a match, then add it to a list to
      * remove from the final sequence (it will make sense later)
      */
-    for (msgnum = reverse ? mp->hghsel : mp->lowsel;
-         reverse ? msgnum >= mp->lowsel : msgnum <= mp->hghsel;
-         msgnum += reverse ? -1 : 1) {
+    if (!reverse) { /* Overflow or underflow is fine. */
+        start = mp->lowsel;
+        end = mp->hghsel + 1;
+        inc = 1;
+    } else {
+        start = mp->hghsel;
+        end = mp->lowsel - 1;
+        inc = -1;
+    }
+    for (msgnum = start; msgnum != end; msgnum += inc) {
        if (is_selected (mp, msgnum)) {
            if ((fp = fopen (cp = m_name (msgnum), "r")) == NULL)
                admonish (cp, "unable to read message");
            if (fp && pmatches (fp, msgnum, 0L, 0L, debug)) {
                if (listsw)
-                   printf ("%s\n", m_name (msgnum));
+                   puts(m_name (msgnum));
            } else {
                app_msgnum(&nums, msgnum);
            }
@@ -316,6 +324,6 @@ static void
 putzero_done (int status)
 {
     if (listsw && status && !isatty (fileno (stdout)))
-       printf ("0\n");
+       puts("0");
     exit (status);
 }