new.c: Order two return statements to match comment.

[nmh] / sbr / fmt_scan.c

diff --git a/sbr/fmt_scan.c b/sbr/fmt_scan.c
index 83e48b8b4306f5beff856db266dcfcb5d80593f0..791146a21a83203925743d1791b40bc247dafe52 100644 (file)
--- a/sbr/fmt_scan.c
+++ b/sbr/fmt_scan.c
@@ -31,7 +31,7 @@ struct mailname fmt_mnull = { NULL, NULL, NULL, NULL, NULL, NULL, 0, 0, 0, 0,
 /*
  * static prototypes
  */
 /*
  * static prototypes
  */

-static int match (char *, char *);
+static int match (char *, char *) PURE;

 static char *get_x400_friendly (char *, char *, int);
 static int get_x400_comp (char *, char *, char *, int);
 
 static char *get_x400_friendly (char *, char *, int);
 static int get_x400_comp (char *, char *, char *, int);
 


@@ -67,8 +67,13 @@ match (char *str, char *sub)
  * copy a number to the destination subject to a maximum width
  */
 void
  * copy a number to the destination subject to a maximum width
  */
 void

-cpnumber(charstring_t dest, int num, unsigned int wid, char fill, size_t max) {
-    if (wid < (num >= 0 ? max : max-1)) {
+cpnumber(charstring_t dest, int num, int wid, char fill, size_t max) {
+    /* Maybe we should handle left padding at some point? */
+    if (wid == 0)
+       return;
+    if (wid < 0)
+        wid = -wid; /* OK because wid originally a short. */
+    if ((size_t)wid < (num >= 0 ? max : max-1)) {

        /* Build up the string representation of num in reverse. */
        charstring_t rev = charstring_create (0);
        int i = num >= 0 ? num : -num;
        /* Build up the string representation of num in reverse. */
        charstring_t rev = charstring_create (0);
        int i = num >= 0 ? num : -num;


@@ -222,75 +227,87 @@ cptrimmed(charstring_t dest, char *str, int wid, char fill, size_t max) {
 static void
 cpstripped (charstring_t dest, size_t max, char *str)
 {
 static void
 cpstripped (charstring_t dest, size_t max, char *str)
 {

-    int prevCtrl = 1;  /* This is 1 so we strip out leading spaces */
-    int len;
-    int char_len, w;
-    wchar_t wide_char;
-    char *altstr = NULL;
-
-    if (!str) {
-       return;
-    }
-
-    len = strlen(str);
+    static bool deja_vu;
+    static char *oddchar;
+    static size_t oddlen;
+    static char *spacechar;
+    static size_t spacelen;
+    char *end;
+    bool squash;
+    char *src;
+    int srclen;
+    wchar_t rune;
+    int w;

 
 

-    if (mbtowc(NULL, NULL, 0)) {}  /* Reset shift state */
+    if (!deja_vu) {
+        size_t two;

 
 

-    /*
-     * Process each character at a time; if we have multibyte support
-     * then deal with that here.
-     */
+        deja_vu = true;

 
 

-    while (*str != '\0' && len > 0 && max > 0) {
-       char_len = mbtowc(&wide_char, str, len);
+        two = MB_CUR_MAX * 2; /* Varies at run-time. */

 
 

-       /*
-        * If mbrtowc() failed, then we have a character that isn't valid
-        * in the current encoding, or len wasn't enough for the whole
-        * multi-byte rune to be read.  Replace it with a '?'.  We do that by
-        * setting the alstr variable to the value of the replacement string;
-        * altstr is used below when the bytes are copied into the output
-        * buffer.
-        */
-       if (char_len < 0) {
-           altstr = "?";
-           char_len = mbtowc(&wide_char, altstr, 1);
-       }
+        oddchar = mh_xmalloc(two);
+        oddlen = wcstombs(oddchar, L"?", two);
+        assert(oddlen > 0);

 
 

-       if (char_len <= 0) {
-           break;
-       }
+        assert(wcwidth(L' ') == 1); /* Need to pad in ones. */
+        spacechar = mh_xmalloc(two);
+        spacelen = wcstombs(spacechar, L" ", two);
+        assert(spacelen > 0);
+    }

 
 

-       len -= char_len;
+    if (!str)
+        return; /* It's unclear why no padding in this case. */
+    end = str + strlen(str);
+
+    if (mbtowc(NULL, NULL, 0))
+        {} /* Reset shift state. */
+
+    squash = true; /* Trim `space' or `cntrl' from the start. */
+    while (max) {
+        if (!*str)
+            return; /* It's unclear why no padding in this case. */
+
+        srclen = mbtowc(&rune, str, end - str);
+        if (srclen == -1) {
+            /* Invalid rune, or not enough bytes to finish it. */
+            rune = L'?';
+            src = oddchar;
+            srclen = oddlen;
+            str++; /* Skip one byte. */
+        } else {
+            src = str;
+            str += srclen;
+        }

 
 

-       if (iswcntrl(wide_char) || iswspace(wide_char)) {
-           str += char_len;
-           if (! prevCtrl) {
-               charstring_push_back (dest, ' ');
-               --max;
-           }
+        if (iswspace(rune) || iswcntrl(rune)) {
+            if (squash)
+                continue; /* Amidst a run of these. */
+            rune = L' ';
+            src = spacechar;
+            srclen = spacelen;
+            squash = true;
+        } else
+            squash = false;
+
+        w = wcwidth(rune);
+        if (w == -1) {
+            rune = L'?';
+            w = wcwidth(rune);
+            assert(w != -1);
+            src = oddchar;
+            srclen = oddlen;
+        }

 
 

-           prevCtrl = 1;
-           continue;
-       }
+        if ((size_t)w > max) {
+            /* No room for rune;  pad. */
+            while (max--)
+                charstring_push_back_chars(dest, spacechar, spacelen, 1);
+            return;
+        }

 
 

-       prevCtrl = 0;
-
-       w = wcwidth(wide_char);
-       assert(w >= 0);
-       if (max >= (size_t) w) {
-           charstring_push_back_chars (dest, altstr ? altstr : str, char_len, w);
-           max -= w;
-           str += char_len;
-           altstr = NULL;
-       } else {
-           /* Not enough width available for the last character.  Output
-              space(s) to fill. */
-           while (max-- > 0) {
-               charstring_push_back (dest, ' ');
-           }
-           break;
-       }
+        charstring_push_back_chars(dest, src, srclen, w);
+        max -= w;

     }
 }
 #endif
     }
 }
 #endif


@@ -299,38 +316,27 @@ cpstripped (charstring_t dest, size_t max, char *str)
 static void
 cpstripped (charstring_t dest, size_t max, char *str)
 {
 static void
 cpstripped (charstring_t dest, size_t max, char *str)
 {

-    int prevCtrl = 1;  /* This is 1 so we strip out leading spaces */
-    int len;
+    bool squash;
+    int c;

 
 

-    if (!str) {
+    if (!str)

        return;
        return;

-    }
-
-    len = strlen(str);
-
-    /*
-     * Process each character at a time; if we have multibyte support
-     * then deal with that here.
-     */
-
-    while (*str != '\0' && len > 0 && max > 0) {
-       int c = (unsigned char) *str;
-       len--;
-       if (iscntrl(c) || isspace(c)) {
-           str++;
-           if (! prevCtrl) {
-               charstring_push_back (dest, ' ');
-               --max;
-           }
-
-           prevCtrl = 1;
-           continue;
-       }
-
-       prevCtrl = 0;

 
 

-       charstring_push_back (dest, *str++);
-        --max;
+    squash = true; /* Strip leading cases. */
+    while (max--) {
+        c = (unsigned char)*str++;
+        if (!c)
+            return;
+
+       if (isspace(c) || iscntrl(c)) {
+            if (squash)
+                continue;
+            c = ' ';
+            squash = true;
+        } else
+            squash = false;
+
+       charstring_push_back(dest, (char)c);

     }
 }
 #endif
     }
 }
 #endif


@@ -835,7 +841,7 @@ fmt_scan (struct format *format, charstring_t scanlp, int width, int *dat,
        case FT_LV_RCLOCK:
            if ((value = fmt->f_comp->c_tws->tw_clock) == 0)
                value = dmktime(fmt->f_comp->c_tws);
        case FT_LV_RCLOCK:
            if ((value = fmt->f_comp->c_tws->tw_clock) == 0)
                value = dmktime(fmt->f_comp->c_tws);

-           value = time((time_t *) 0) - value;
+           value = time(NULL) - value;

            break;
        case FT_LV_DAYF:
            if (!(((tws = fmt->f_comp->c_tws)->tw_flags) & (TW_SEXP|TW_SIMP)))
            break;
        case FT_LV_DAYF:
            if (!(((tws = fmt->f_comp->c_tws)->tw_flags) & (TW_SEXP|TW_SIMP)))


@@ -983,7 +989,7 @@ fmt_scan (struct format *format, charstring_t scanlp, int width, int *dat,
                *comp->c_tws = *tws;
                comp->c_flags &= ~CF_TRUE;
            } else if ((comp->c_flags & CF_DATEFAB) == 0) {
                *comp->c_tws = *tws;
                comp->c_flags &= ~CF_TRUE;
            } else if ((comp->c_flags & CF_DATEFAB) == 0) {

-               memset (comp->c_tws, 0, sizeof *comp->c_tws);
+               ZERO(comp->c_tws);

                comp->c_flags = CF_TRUE;
            }
            comp->c_flags |= CF_PARSED;
                comp->c_flags = CF_TRUE;
            }
            comp->c_flags |= CF_PARSED;


@@ -1200,5 +1206,5 @@ fmt_scan (struct format *format, charstring_t scanlp, int width, int *dat,
        }
     }
 
        }
     }
 

-    return (NULL);
+    return NULL;

 }
 }