Alter HasSuffixC()'s char * to be const.

[nmh] / uip / sendsbr.c

diff --git a/uip/sendsbr.c b/uip/sendsbr.c
index 89894af58a1978cad7343fa29717fd6c9bdfc3df..497c868b2bbfb229ae8f603b7a9da5ffc3e0db7a 100644 (file)
--- a/uip/sendsbr.c
+++ b/uip/sendsbr.c
@@ -26,7 +26,7 @@
 #ifdef OAUTH_SUPPORT
 #include <h/oauth.h>
 
 #ifdef OAUTH_SUPPORT
 #include <h/oauth.h>
 

-static int setup_oauth_params(char *[], int *, int, const char **);
+static int setup_oauth_params(char *[], int *, const char *, const char **);

 #endif /* OAUTH_SUPPORT */
 
 int debugsw = 0;               /* global */
 #endif /* OAUTH_SUPPORT */
 
 int debugsw = 0;               /* global */


@@ -52,7 +52,7 @@ static void anno (int, struct stat *);
 static void annoaux (int);
 static int splitmsg (char **, int, char *, char *, struct stat *, int);
 static int sendaux (char **, int, char *, char *, struct stat *);
 static void annoaux (int);
 static int splitmsg (char **, int, char *, char *, struct stat *, int);
 static int sendaux (char **, int, char *, char *, struct stat *);

-static void handle_sendfrom(char **, int *, char *);
+static void handle_sendfrom(char **, int *, char *, const char *);

 static int get_from_header_info(const char *, const char **, const char **, const char **);
 static const char *get_message_header_info(FILE *, char *);
 static void merge_profile_entry(const char *, const char *, char *[], int *);
 static int get_from_header_info(const char *, const char **, const char **, const char **);
 static const char *get_message_header_info(FILE *, char *);
 static void merge_profile_entry(const char *, const char *, char *[], int *);


@@ -64,7 +64,7 @@ static void armed_done (int) NORETURN;
 
 int
 sendsbr (char **vec, int vecp, char *program, char *draft, struct stat *st,
 
 int
 sendsbr (char **vec, int vecp, char *program, char *draft, struct stat *st,

-         int rename_drft)
+         int rename_drft, const char *auth_svc)

 {
     int status, i;
     pid_t child;
 {
     int status, i;
     pid_t child;


@@ -88,7 +88,7 @@ sendsbr (char **vec, int vecp, char *program, char *draft, struct stat *st,
        break;
 
     case OK:
        break;
 
     case OK:

-       buildvec = argsplit(buildmimeproc, &buildprogram, &i);
+        buildvec = argsplit(buildmimeproc, &buildprogram, &i);

        buildvec[i++] = "-auto";
        if (distfile)
            buildvec[i++] = "-dist";
        buildvec[i++] = "-auto";
        if (distfile)
            buildvec[i++] = "-dist";


@@ -124,12 +124,28 @@ sendsbr (char **vec, int vecp, char *program, char *draft, struct stat *st,
            drft = file;
        }
 
            drft = file;
        }
 

+       /*
+        * Add in any necessary profile entries for xoauth
+        */
+
+       if (auth_svc) {
+#ifdef OAUTH_SUPPORT
+               const char *errmsg;
+               if (setup_oauth_params(vec, nvecsp, auth_svc, &errmsg) != OK) {
+                       adios(NULL, errmsg);
+               }
+#else
+                adios(NULL, "send built without OAUTH_SUPPORT, "
+                      "so auth_svc %s is not supported", auth_svc);
+#endif /* OAUTH_SUPPORT */
+       }
+

         /*
          * Rework the vec based on From: header in draft, as specified
          * by sendfrom-address entries in profile.
          */
         if (context_find_prefix("sendfrom-")) {
         /*
          * Rework the vec based on From: header in draft, as specified
          * by sendfrom-address entries in profile.
          */
         if (context_find_prefix("sendfrom-")) {

-            handle_sendfrom(vec, nvecsp, draft);
+            handle_sendfrom(vec, nvecsp, draft, auth_svc);

         }
 
        /*
         }
 
        /*


@@ -282,8 +298,7 @@ splitmsg (char **vec, int vecp, char *program, char *drft,
     /* Only one part, nothing to split */
     if (nparts == 1) {
        free (cp);
     /* Only one part, nothing to split */
     if (nparts == 1) {
        free (cp);

-       if (dp)
-           free (dp);
+        mh_xfree(dp);

 
        fclose (in);
        return sendaux (vec, vecp, program, drft, st);
 
        fclose (in);
        return sendaux (vec, vecp, program, drft, st);


@@ -361,7 +376,7 @@ splitmsg (char **vec, int vecp, char *program, char *drft,
        fclose (out);
 
        if (!pushsw && verbsw) {
        fclose (out);
 
        if (!pushsw && verbsw) {

-           printf ("\n");
+           putchar('\n');

            fflush (stdout);
        }
 
            fflush (stdout);
        }
 


@@ -389,8 +404,7 @@ splitmsg (char **vec, int vecp, char *program, char *drft,
     }
 
     free (cp);
     }
 
     free (cp);

-    if (dp)
-       free (dp);
+    mh_xfree(dp);

 
     fclose (in);       /* close the draft */
     return status;
 
     fclose (in);       /* close the draft */
     return status;


@@ -606,7 +620,7 @@ anno (int fd, struct stat *st)
                advise (NULL,
                            "unable to fork, so doing annotations by hand...");
            if (cwd == NULL)
                advise (NULL,
                            "unable to fork, so doing annotations by hand...");
            if (cwd == NULL)

-               cwd = getcpy (pwd ());
+               cwd = mh_xstrdup(pwd ());

 
        case OK:
            /* block a few signals */
 
        case OK:
            /* block a few signals */


@@ -685,7 +699,7 @@ annoaux (int fd)
     }
     else
        fd2 = NOTOK;
     }
     else
        fd2 = NOTOK;

-    for (ap = brkstring (cp = getcpy (cp), " ", NULL); *ap; ap++)
+    for (ap = brkstring (cp = mh_xstrdup(cp), " ", NULL); *ap; ap++)

        m_convert (mp, *ap);
     free (cp);
     if (fd2 != NOTOK)
        m_convert (mp, *ap);
     free (cp);
     if (fd2 != NOTOK)


@@ -727,7 +741,7 @@ oops:
 
 static
 void
 
 static
 void

-handle_sendfrom(char **vec, int *vecp, char *draft) {
+handle_sendfrom(char **vec, int *vecp, char *draft, const char *auth_svc) {

     const char *addr, *host;
     const char *message;
 
     const char *addr, *host;
     const char *message;
 


@@ -749,22 +763,13 @@ handle_sendfrom(char **vec, int *vecp, char *draft) {
         for (vp = vec; *vp; ++vp) {
             if (strcmp(*vp, "xoauth2") == 0) {
 #ifdef OAUTH_SUPPORT
         for (vp = vec; *vp; ++vp) {
             if (strcmp(*vp, "xoauth2") == 0) {
 #ifdef OAUTH_SUPPORT

-                int snoop = 0;
-
-                /* -snoop will be in vec if it was enabled. */
-                for (vp = vec; vp && *vp; ++vp) {
-                    if (strcmp(*vp, "-snoop") == 0) {
-                        snoop = 1;
-                        break;
-                    }
-                }
-
-                if (setup_oauth_params(vec, vecp, snoop, &message) != OK) {
+                if (setup_oauth_params(vec, vecp, auth_svc, &message) != OK) {

                     adios(NULL, message);
                 }
                 break;
 #else
                     adios(NULL, message);
                 }
                 break;
 #else

-                adios(NULL, "sendfrom built without OAUTH_SUPPORT, "
+                NMH_UNUSED(auth_svc);
+                adios(NULL, "send built without OAUTH_SUPPORT, "

                       "so -saslmech xoauth2 is not supported");
 #endif /* OAUTH_SUPPORT */
             }
                       "so -saslmech xoauth2 is not supported");
 #endif /* OAUTH_SUPPORT */
             }


@@ -775,12 +780,14 @@ handle_sendfrom(char **vec, int *vecp, char *draft) {
 
 #ifdef OAUTH_SUPPORT
 /*
 
 #ifdef OAUTH_SUPPORT
 /*

- * For XOAUTH2, append access token, from mh_oauth_do_xoauth(), for the user to vec.
+ * For XOAUTH2, append profile entries so post can do the heavy lifting

  */
  */

-static
-int
-setup_oauth_params(char *vec[], int *vecp, int snoop, const char **message) {
-    const char *saslmech = NULL, *user = NULL, *auth_svc = NULL;
+static int
+setup_oauth_params(char *vec[], int *vecp, const char *auth_svc,
+                  const char **message) {
+    const char *saslmech = NULL, *user = NULL;
+    mh_oauth_service_info svc;
+    char errbuf[256];

     int i;
 
     /* Make sure we have all the information we need. */
     int i;
 
     /* Make sure we have all the information we need. */


@@ -807,11 +814,28 @@ setup_oauth_params(char *vec[], int *vecp, int snoop, const char **message) {
             return NOTOK;
         }
 
             return NOTOK;
         }
 

-        vec[(*vecp)++] = getcpy("-authservice");

         if (saslmech  &&  ! strcasecmp(saslmech, "xoauth2")) {
         if (saslmech  &&  ! strcasecmp(saslmech, "xoauth2")) {

-            vec[(*vecp)++] = mh_oauth_do_xoauth(user, auth_svc, snoop ? stderr : NULL);
-        } else {
-            vec[(*vecp)++] = getcpy(auth_svc);
+           if (! mh_oauth_get_service_info(auth_svc, &svc, errbuf,
+                                           sizeof(errbuf)))
+               adios(NULL, "Unable to retrieve oauth profile entries: %s",
+                     errbuf);
+
+           vec[(*vecp)++] = mh_xstrdup("-authservice");
+           vec[(*vecp)++] = mh_xstrdup(auth_svc);
+           vec[(*vecp)++] = mh_xstrdup("-oauthcredfile");
+           vec[(*vecp)++] = mh_xstrdup(mh_oauth_cred_fn(auth_svc));
+           vec[(*vecp)++] = mh_xstrdup("-oauthclientid");
+           vec[(*vecp)++] = getcpy(svc.client_id);
+           vec[(*vecp)++] = mh_xstrdup("-oauthclientsecret");
+           vec[(*vecp)++] = getcpy(svc.client_secret);
+           vec[(*vecp)++] = mh_xstrdup("-oauthauthendpoint");
+           vec[(*vecp)++] = getcpy(svc.auth_endpoint);
+           vec[(*vecp)++] = mh_xstrdup("-oauthredirect");
+           vec[(*vecp)++] = getcpy(svc.redirect_uri);
+           vec[(*vecp)++] = mh_xstrdup("-oauthtokenendpoint");
+           vec[(*vecp)++] = getcpy(svc.token_endpoint);
+           vec[(*vecp)++] = mh_xstrdup("-oauthscope");
+           vec[(*vecp)++] = getcpy(svc.scope);

         }
     }
 
         }
     }
 


@@ -841,7 +865,7 @@ get_from_header_info(const char *filename, const char **addr, const char **host,
         char *hostformat = "%(host{Envelope-From})";
 
         if ((*addr = get_message_header_info (in, addrformat)) == NULL  ||
         char *hostformat = "%(host{Envelope-From})";
 
         if ((*addr = get_message_header_info (in, addrformat)) == NULL  ||

-            strlen (*addr) == 0) {
+            !**addr) {

             addrformat = distfile == NULL  ?  "%(addr{Sender})"  :  "%(addr{Resent-Sender})";
             hostformat = distfile == NULL  ?  "%(host{Sender})"  :  "%(host{Resent-Sender})";
 
             addrformat = distfile == NULL  ?  "%(addr{Sender})"  :  "%(addr{Resent-Sender})";
             hostformat = distfile == NULL  ?  "%(host{Sender})"  :  "%(host{Resent-Sender})";
 


@@ -867,10 +891,10 @@ get_from_header_info(const char *filename, const char **addr, const char **host,
         fclose(in);
 
         return OK;
         fclose(in);
 
         return OK;

-    } else {
-        *message = "unable to open";
-        return NOTOK;

     }
     }

+
+    *message = "unable to open";
+    return NOTOK;

 }
 
 
 }
 
 


@@ -937,12 +961,11 @@ get_message_header_info(FILE *in, char *format) {
     /* Trim trailing newline, if any. */
     retval = rtrim(charstring_buffer_copy((buffer)));
     charstring_free(buffer);
     /* Trim trailing newline, if any. */
     retval = rtrim(charstring_buffer_copy((buffer)));
     charstring_free(buffer);

-    if (strlen (retval) > 0) {
+    if (*retval)

         return retval;
         return retval;

-    } else {
-        free (retval);
-        return NULL;
-    }
+
+    free(retval);
+    return NULL;

 }
 
 
 }
 
 


@@ -972,7 +995,7 @@ merge_profile_entry(const char *addr, const char *host, char *vec[], int *vecp)
     }
 
     /* Use argsplit() to do the real work of splitting the args in the profile entry. */
     }
 
     /* Use argsplit() to do the real work of splitting the args in the profile entry. */

-    if (profile_entry  &&  strlen(profile_entry) > 0) {
+    if (profile_entry && *profile_entry) {

         int profile_vecp;
         char *file;
         char **profile_vec = argsplit(profile_entry, &file, &profile_vecp);
         int profile_vecp;
         char *file;
         char **profile_vec = argsplit(profile_entry, &file, &profile_vecp);