lock_file.c: close(2) file descriptor on failure, avoiding leak.

[nmh] / uip / send.c

diff --git a/uip/send.c b/uip/send.c
index 2d162a7a829f7d8a5fd6f59d735801375f11acdc..1f419f57194f46442ba49e042a5309c4d18455a3 100644 (file)
--- a/uip/send.c
+++ b/uip/send.c
@@ -1,6 +1,4 @@
-
-/*
- * send.c -- send a composed message
+/* send.c -- send a composed message
  *
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
@@ -10,10 +8,11 @@
 #include <h/mh.h>
 #include <fcntl.h>
 #include <h/utils.h>
-
 #ifdef OAUTH_SUPPORT
 # include <h/oauth.h>
 #endif
+#include "sbr/m_maildir.h"
+#include "sbr/m_mktemp.h"
 
 #ifndef CYRUS_SASL
 # define SASLminc(a) (a)
@@ -66,9 +65,6 @@
     X("saslmech mechanism", SASLminc(6), SASLMECHSW) \
     X("authservice", SASLminc(0), AUTHSERVICESW) \
     X("user username", SASLminc(-4), USERSW) \
-    X("attach", -6, ATTACHSW) \
-    X("noattach", -8, NOATTACHSW) \
-    X("attachformat", 7, ATTACHFORMATSW) \
     X("port server-port-name/number", 4, PORTSW) \
     X("tls", TLSminc(-3), TLSSW) \
     X("initialtls", TLSminc(-10), INITTLSSW) \
@@ -243,7 +239,8 @@ main (int argc, char **argv)
                    continue;
 
                case DEBUGSW: 
-                   debugsw++;  /* fall */
+                   debugsw++;
+                   /* FALLTHRU */
                case NFILTSW: 
                case FRMTSW: 
                case NFRMTSW: 
@@ -283,7 +280,7 @@ main (int argc, char **argv)
                case SASLMECHSW:
                    if (!(saslmech = *argp) || *saslmech == '-')
                        adios (NULL, "missing argument to %s", argp[-1]);
-                   /* Fall through */
+                   /* FALLTHRU */
 
                case ALIASW: 
                case FILTSW: 
@@ -299,17 +296,6 @@ main (int argc, char **argv)
                        adios (NULL, "missing argument to %s", argp[-2]);
                    vec[vecp++] = cp;
                    continue;
-               
-               case ATTACHSW:
-                   advise(NULL, "The -attach switch is deprecated");
-                   continue;
-               case NOATTACHSW:
-                   advise(NULL, "The -noattach switch is deprecated");
-                   continue;
-
-               case ATTACHFORMATSW:
-                   advise(NULL, "The -attachformat switch is deprecated");
-                   continue;
            }
        } else {
            msgs[msgp++] = cp;
@@ -346,7 +332,7 @@ main (int argc, char **argv)
                        showfile (++argp, msgs[0]);
                        break;
                    default:
-                       advise (NULL, "say what?");
+                       inform("say what?");
                        break;
                }
            }
@@ -396,7 +382,7 @@ go_to_it:
 
     if ((cp = getenv ("SIGNATURE")) == NULL || *cp == 0)
        if ((cp = context_find ("signature")) && *cp)
-           m_putenv ("SIGNATURE", cp);
+           setenv("SIGNATURE", cp, 1);
 
     for (msgnum = 0; msgnum < msgp; msgnum++)
        if (stat (msgs[msgnum], &st) == NOTOK)
@@ -483,8 +469,10 @@ go_to_it:
         switch (sendsbr (vec, vecp, program, msgs[msgnum], &st, 1, auth_svc)) {
            case DONE: 
                done (++status);
+               /* FALLTHRU */
            case NOTOK: 
-               status++;       /* fall */
+               status++;
+               /* FALLTHRU */
            case OK:
                break;
        }