Replace getcpy() with mh_xstrdup() where the string isn't NULL.

[nmh] / sbr / error.c

diff --git a/sbr/error.c b/sbr/error.c
index 299e3a6206a0b2a6fdecdaeba68f8a1ceb06a458..c23c3dfa3072cb996757bb6a7f140714447c65ea 100644 (file)
--- a/sbr/error.c
+++ b/sbr/error.c
@@ -2,8 +2,6 @@
 /*
  * error.c -- main error handling routines
  *
 /*
  * error.c -- main error handling routines
  *

- * $Id$
- *

  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
  * complete copyright information.
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
  * complete copyright information.


@@ -11,19 +9,15 @@
 
 #include <h/mh.h>
 
 
 #include <h/mh.h>
 

-#ifdef HAVE_WRITEV
-# include <sys/types.h>
-# include <sys/uio.h>
-#endif
-
-#include <errno.h>
+#include <sys/types.h>
+#include <sys/uio.h>

 
 
 /*
  * print out error message
  */
 void
 
 
 /*
  * print out error message
  */
 void

-advise (char *what, char *fmt, ...)
+advise (const char *what, const char *fmt, ...)

 {
     va_list ap;
 
 {
     va_list ap;
 


@@ -37,7 +31,7 @@ advise (char *what, char *fmt, ...)
  * print out error message and exit
  */
 void
  * print out error message and exit
  */
 void

-adios (char *what, char *fmt, ...)
+adios (const char *what, const char *fmt, ...)

 {
     va_list ap;
 
 {
     va_list ap;
 


@@ -64,25 +58,16 @@ admonish (char *what, char *fmt, ...)
 
 /*
  * main routine for printing error messages.
 
 /*
  * main routine for printing error messages.

- *
- * Use writev() if available, for slightly better performance.
- * Why?  Well, there are a couple of reasons.  Primarily, it
- * gives a smoother output...  More importantly though, it's a
- * sexy syscall()...

  */
 void
  */
 void

-advertise (char *what, char *tail, char *fmt, va_list ap)
+advertise (const char *what, char *tail, const char *fmt, va_list ap)

 {
     int        eindex = errno;
 {
     int        eindex = errno;

-
-#ifdef HAVE_WRITEV

     char buffer[BUFSIZ], err[BUFSIZ];
     struct iovec iob[20], *iov;
     char buffer[BUFSIZ], err[BUFSIZ];
     struct iovec iob[20], *iov;

-#endif

 
     fflush (stdout);
 
 
     fflush (stdout);
 

-#ifdef HAVE_WRITEV

     fflush (stderr);
     iov = iob;
 
     fflush (stderr);
     iov = iob;
 


@@ -100,7 +85,7 @@ advertise (char *what, char *tail, char *fmt, va_list ap)
        if (*what) {
            iov->iov_len = strlen (iov->iov_base = " ");
            iov++;
        if (*what) {
            iov->iov_len = strlen (iov->iov_base = " ");
            iov++;

-           iov->iov_len = strlen (iov->iov_base = what);
+           iov->iov_len = strlen (iov->iov_base = (void*)what);

            iov++;
            iov->iov_len = strlen (iov->iov_base = ": ");
            iov++;
            iov++;
            iov->iov_len = strlen (iov->iov_base = ": ");
            iov++;


@@ -121,24 +106,7 @@ advertise (char *what, char *tail, char *fmt, va_list ap)
     }
     iov->iov_len = strlen (iov->iov_base = "\n");
     iov++;
     }
     iov->iov_len = strlen (iov->iov_base = "\n");
     iov++;

-    writev (fileno (stderr), iob, iov - iob);
-#else
-    if (invo_name && *invo_name)
-       fprintf (stderr, "%s: ", invo_name);
-    vfprintf (stderr, fmt, ap);
-
-    if (what) {
-       char *s;
-
-       if (*what)
-           fprintf (stderr, " %s: ", what);
-       if ((s = strerror(eindex)))
-           fprintf (stderr, "%s", s);
-       else
-           fprintf (stderr, "Error %d", eindex);
+    if (writev (fileno (stderr), iob, iov - iob) < 0) {
+       advise ("stderr", "writev");

     }
     }

-    if (tail)
-       fprintf (stderr, ", %s", tail);
-    fputc ('\n', stderr);
-#endif

 }
 }