Use "script file" in test-version-check for maximum portability.

[nmh] / test / install-mh / test-version-check

diff --git a/test/install-mh/test-version-check b/test/install-mh/test-version-check
index 591eb1ee65f8b2b558b521e5890e8588c9851b33..def3cda465b77e7c9aefda23389dfc4019da92a6 100755 (executable)
--- a/test/install-mh/test-version-check
+++ b/test/install-mh/test-version-check
@@ -18,6 +18,10 @@ fi
 setup_test
 
 require_prog script
+#### Use minimal arguments to script(1), i.e., just the file in
+#### which to save the output.  We do pipe input to script, which is
+#### discouraged by the NOTES and BUGS sections of its man page.
+#### But that seems to work.
 
 actual="$MH_TEST_DIR/test-version-check$$.actual"
 context="${MH_TEST_DIR}"/Mail/context
@@ -30,83 +34,68 @@ mv -f "$context.NEW" "$context"
 
 
 start_test 'mhparam skips the welcome message'
-# The command will wait for the user to hit return.  script seems to do what
-# we want by not waiting when run in the background.
-script -c 'mhparam path last' -f -q "$actual" >/dev/null &
-wait $!
+printf 'mhparam path\nexit\n' | script "$actual" >/dev/null
 grep 'Welcome to nmh version ' "$actual" >/dev/null  &&  false
-rm "$actual"
 # Make sure that version wasn't added to context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null  &&  false
-finish_test
+rm "$actual"
 
 
 start_test 'Welcome: disable in profile skips the welcome message'
 cp "${MH}" "${MH}-welcome"
 printf 'Welcome: disable\n' >> "${MH}-welcome"
-MH="${MH}-welcome" script -c 'pick last' -f -q "$actual" >/dev/null &
-wait $!
+(printf 'pick last\nexit\n' | MH="${MH}-welcome" script "$actual" >/dev/null)
 grep 'Welcome to nmh version ' "$actual" >/dev/null  &&  false
-rm "$actual"
 # Make sure that version wasn't added to context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null  &&  false
-finish_test
+rm "$actual"
 
 
 start_test 'with welcome message'
-script -c 'pick last' -f -q "$actual" >/dev/null &
-wait $!
+printf 'pick last\nexit\n' | script "$actual" >/dev/null
 grep 'Welcome to nmh version ' "$actual" >/dev/null
-rm "$actual"
 # Make sure that version was added to context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null
-finish_test
+rm "$actual"
 
 
 start_test 'without welcome message'
 # After running the previous test, this one should not have
 # the welcome message.
-script -c 'pick last' -f -q "$actual" >/dev/null &
-wait $!
+printf 'pick last\nexit\n' | script "$actual" >/dev/null
 grep 'Welcome to nmh version ' "$actual" >/dev/null  &&  false
-rm "$actual"
 # Make sure that version is still in context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null
-finish_test
+rm "$actual"
 
 
 start_test 'with MHCONTEXT, welcome only if older'
 MHCONTEXT="${MH_TEST_DIR}/Mail/context2"; export MHCONTEXT
 printf 'Version: nmh-1.5\n' >"${MHCONTEXT}"
-script -c 'pick last' -f -q "$actual" >/dev/null &
-wait $!
+printf 'pick last\nexit\n' | script "$actual" >/dev/null
 grep 'Welcome to nmh version ' "$actual" >/dev/null
 # And make sure that version did get updated in context.
 grep "^${version}$" "${MHCONTEXT}" >/dev/null
 rm "$actual"
-finish_test
 
 
 start_test "with MHCONTEXT doesn't welcome if newer"
 printf 'Version: nmh-10000.0\n' >"${MHCONTEXT}"
-script -c 'pick last' -f -q "$actual" >/dev/null &
-wait $!
+printf 'pick last\nexit\n' | script "$actual" >/dev/null
 grep 'Welcome to nmh version ' "$actual" >/dev/null  &&  false
-rm "$actual"
 # And make sure that version didn't get updated in context.
 grep '^Version: nmh-10000.0$' "${MHCONTEXT}" >/dev/null
-finish_test
+rm "$actual"
 
 
 start_test 'with MHCONTEXT but no version, no welcome and update'
 printf '' >"${MHCONTEXT}"
-script -c 'pick last' -f -q "$actual" >/dev/null &
-wait $!
+printf 'pick last\nexit\n' | script "$actual" >/dev/null
 grep 'Welcome to nmh version ' "$actual" >/dev/null  &&  false
 # And make sure that version did get updated in context.
 grep "^${version}$" "${MHCONTEXT}" >/dev/null
 rm "$actual"
-finish_test
 
 
+finish_test
 exit $failed