When I fixed the long-standing makedir() bugs in January, I had the code call

[nmh] / ChangeLog

diff --git a/ChangeLog b/ChangeLog
index f4dfb1a57899ddd265cb2c23298f3cbbe4e15c32..62dfdf3d1ad3b3d20c04b3632c2f366b3b3461f5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,19 @@
-Tue Mar 14 01:14:13 2000 Dan Harkless <dan-nmh@dilvish.speed.net>
+Wed Mar 15 14:20:20 2000 Dan Harkless <dan-nmh@dilvish.speed.net>
+
+       * When I fixed the long-standing makedir() bugs in January, I had
+       the code call strtoul(..., 0), which I believed to be safe as all
+       modes specified as ASCII constants in the nmh code started with a
+       leading zero (signifying octal), which I did as it would work if
+       internal constants were ever changed to hex.  Unfortunately I was
+       unaware of the "Folder-Protect:" .mh_profile entry, which
+       mh-profile.man documents as an octal-only constant, with no
+       leading zero required.  I've changed the strtoul() call to an
+       atooi() call and removed the misleading leading zeroes on the
+       ASCII octal constants in the code and man pages.  Also changed the
+       "Folder-Protect:" example in the man page to something more
+       interesting than a duplication of the default.
+
+Tue Mar 14 12:41:48 2000 Dan Harkless <dan-nmh@dilvish.speed.net>
 
        * Applied, after some finessing,
        Simon Burge <simonb@thistledown.com.au>'s --with-smtpservers patch:
@@ -31,6 +46,30 @@ Tue Mar 14 01:14:13 2000 Dan Harkless <dan-nmh@dilvish.speed.net>
        --enable-masquerade or --with-smtpservers, you'll fail to get an
        updated copy of mts.conf.
 
+       * Applied Simon Burge <simonb@thistledown.com.au>'s dtimep.lex patch:
+
+           It seems that some MUA's didn't handle y2k very well - ELM
+           seems to be one of them, and Ultrix's DXmail (based on MH!).
+           I've got a few emails this month that look like:
+
+                   575   Jan 00  Xxxxxx Xxxx       3603  ...
+           and
+                    22+  Jan 00  Xxx Xxxxx         1771  ...
+
+           The first has "15 Jan 100" as the date and the second has 
+           "19 Jan 00" as the date.  The following works around this so 
+           that scan, show, sortm, etc work ok.
+
+       I put Simon's patch under the control of a new #define called
+       FIX_NON_Y2K_COMPLIANT_MUA_DATES.  There's some commentary in
+       acconfig.h about when you might not want to #define it.
+
+       * Created new dtimep.c-lexed with Simon's change using dtimep.lex
+       lexed on Solaris 2.6.  Added missing dependency in
+       zotnet/tws/Makefile.in for dtimep.c: dtimep.c-lexed.
+
+       * Added scan.MMDDYY and scan.YYYYMMDD format files.
+
 Mon Mar 13 21:32:00 2000 Dan Harkless <dan-nmh@dilvish.speed.net>
 
        * Applied Sullivan N. Beck <sbeck@cise.ufl.edu>'s mhshow-suffix patch:
@@ -191,11 +230,12 @@ Fri Jan 28 17:39:24 2000 Dan Harkless <dan-nmh@dilvish.speed.net>
 
 Thu Jan 27 12:22:25 2000 Dan Harkless <dan-nmh@dilvish.speed.net>
 
-       * makedir() had multiple bugs dating back to MH.  It passed an
-       octal constant to atoi(), which interpreted it as decimal,
-       resulting in directories with no user read or execute permissions,
-       making nested directory creation fail.  Also, when creating a
-       nested directory, correct permissions were only set on the inner one.
+       * makedir() had multiple bugs dating back to MH.  An octal
+       constant was apparently being interpreted as decimal, resulting in
+       directories with no user read or execute permissions, making
+       nested directory creation fail.  And there wasn't even an
+       _attempt_ to set desired permissions (e.g. from "Folder-Protect:"
+       in .mh_profile) on the outer directories of a nested directory.
 
        * A second `make install' would always fail because the check for
        whether mh_profile.5 existed was written incorrectly.