lock_file.c: close(2) file descriptor on failure, avoiding leak.

[nmh] / uip / whatnowsbr.c

diff --git a/uip/whatnowsbr.c b/uip/whatnowsbr.c
index 5a73738e72796a191b9b249dd4cfed3b02ed42f0..72b315f41be2b7c24b724a112e4c263fa46ea0bc 100644 (file)
--- a/uip/whatnowsbr.c
+++ b/uip/whatnowsbr.c
@@ -1,6 +1,4 @@
-
-/*
- * whatnowsbr.c -- the WhatNow shell
+/* whatnowsbr.c -- the WhatNow shell

  *
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
  *
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for


@@ -43,10 +41,12 @@
 #include <fcntl.h>
 #include <h/mime.h>
 #include <h/utils.h>
 #include <fcntl.h>
 #include <h/mime.h>
 #include <h/utils.h>

-

 #ifdef OAUTH_SUPPORT
 # include <h/oauth.h>
 #endif
 #ifdef OAUTH_SUPPORT
 # include <h/oauth.h>
 #endif

+#include "sbr/m_maildir.h"
+#include "sbr/m_mktemp.h"
+#include "sbr/mime_type.h"

 
 #define WHATNOW_SWITCHES \
     X("draftfolder +folder", 0, DFOLDSW) \
 
 #define WHATNOW_SWITCHES \
     X("draftfolder +folder", 0, DFOLDSW) \


@@ -57,8 +57,6 @@
     X("prompt string", 4, PRMPTSW) \
     X("version", 0, VERSIONSW) \
     X("help", 0, HELPSW) \
     X("prompt string", 4, PRMPTSW) \
     X("version", 0, VERSIONSW) \
     X("help", 0, HELPSW) \

-    X("attach header-field-name", -6, ATTACHSW) \
-    X("noattach", -8, NOATTACHSW) \

 
 
 #define X(sw, minchars, id) id,
 
 
 #define X(sw, minchars, id) id,


@@ -197,20 +195,11 @@ WhatNow (int argc, char **argv)
                if (!(myprompt = *argp++) || *myprompt == '-')
                    adios (NULL, "missing argument to %s", argp[-2]);
                continue;
                if (!(myprompt = *argp++) || *myprompt == '-')
                    adios (NULL, "missing argument to %s", argp[-2]);
                continue;

-
-           case ATTACHSW:
-               advise(NULL, "The -attach switch is deprecated");
-               continue;
-
-           case NOATTACHSW:
-               advise(NULL, "The -noattach switch is deprecated");
-               continue;

            }
        }
        if (drft)
            adios (NULL, "only one draft at a time!");
            }
        }
        if (drft)
            adios (NULL, "only one draft at a time!");

-       else
-           drft = cp;
+        drft = cp;

     }
 
     if ((drft == NULL && (drft = getenv ("mhdraft")) == NULL) || *drft == 0)
     }
 
     if ((drft == NULL && (drft = getenv ("mhdraft")) == NULL) || *drft == 0)


@@ -250,7 +239,7 @@ WhatNow (int argc, char **argv)
            if (msgnam)
                showfile (++argp, msgnam);
            else
            if (msgnam)
                showfile (++argp, msgnam);
            else

-               advise (NULL, "no alternate message to display");
+               inform("no alternate message to display");

            break;
 
        case BUILDMIMESW:
            break;
 
        case BUILDMIMESW:


@@ -284,7 +273,7 @@ WhatNow (int argc, char **argv)
                removefile (drft);
            } else {
                if (stat (drft, &st) != NOTOK)
                removefile (drft);
            } else {
                if (stat (drft, &st) != NOTOK)

-                   advise (NULL, "draft left on %s", drft);
+                   inform("draft left on %s", drft);

            }
            done (1);
 
            }
            done (1);
 


@@ -328,7 +317,7 @@ WhatNow (int argc, char **argv)
                if (fgets(cwd, sizeof (cwd), f) == NULL) {
                    advise (buf, "fgets");
                }
                if (fgets(cwd, sizeof (cwd), f) == NULL) {
                    advise (buf, "fgets");
                }

-                TrimSuffixC(cwd, '\n');
+                trim_suffix_c(cwd, '\n');

                pclose(f);
            }
            else {
                pclose(f);
            }
            else {


@@ -385,7 +374,7 @@ WhatNow (int argc, char **argv)
            }
 
            if (n == -1)
            }
 
            if (n == -1)

-               advise(NULL, "usage is alist [-ln].");
+               inform("usage is alist [-ln].");

 
            else
                annolist(drft, ATTACH_FIELD, l, n);
 
            else
                annolist(drft, ATTACH_FIELD, l, n);


@@ -413,7 +402,7 @@ WhatNow (int argc, char **argv)
            }
 
            if (*(argp+1) == NULL) {
            }
 
            if (*(argp+1) == NULL) {

-               advise(NULL, "attach command requires file argument(s).");
+               inform("attach command requires file argument(s).");

                break;
            }
 
                break;
            }
 


@@ -435,7 +424,7 @@ WhatNow (int argc, char **argv)
                while (fgets(shell, sizeof (shell), f) != NULL) {
                    char *ctype;
 
                while (fgets(shell, sizeof (shell), f) != NULL) {
                    char *ctype;
 

-                    TrimSuffixC(shell, '\n');
+                    trim_suffix_c(shell, '\n');

 
                    if (*shell == '/') {
                        strncpy(file, shell, sizeof(file));
 
                    if (*shell == '/') {
                        strncpy(file, shell, sizeof(file));


@@ -520,7 +509,7 @@ WhatNow (int argc, char **argv)
            writelscmd(buf, sizeof(buf), "-d --", argp);
            if ((f = popen_in_dir(cwd, buf, "r")) != NULL) {
                while (fgets(shell, sizeof (shell), f) != NULL) {
            writelscmd(buf, sizeof(buf), "-d --", argp);
            if ((f = popen_in_dir(cwd, buf, "r")) != NULL) {
                while (fgets(shell, sizeof (shell), f) != NULL) {

-                    TrimSuffixC(shell, '\n');
+                    trim_suffix_c(shell, '\n');

                    annotate(drft, ATTACH_FIELD, shell, 1, 0, 0, 1);
                }
                pclose(f);
                    annotate(drft, ATTACH_FIELD, shell, 1, 0, 0, 1);
                }
                pclose(f);


@@ -532,7 +521,7 @@ WhatNow (int argc, char **argv)
 
        default:
            /* Unknown command */
 
        default:
            /* Unknown command */

-           advise (NULL, "say what?");
+           inform("say what?");

            break;
        }
     }
            break;
        }
     }


@@ -718,8 +707,8 @@ editfile (char **ed, char **arg, char *file, int use, struct msgs *mp,
            }
            if (altmsg) {
                if (mp)
            }
            if (altmsg) {
                if (mp)

-                   m_putenv ("mhfolder", mp->foldpath);
-               m_putenv ("editalt", altpath);
+                   setenv("mhfolder", mp->foldpath, 1);
+               setenv("editalt", altpath, 1);

            }
 
            vec = argsplit(*ed, &prog, &vecp);
            }
 
            vec = argsplit(*ed, &prog, &vecp);


@@ -741,9 +730,9 @@ editfile (char **ed, char **arg, char *file, int use, struct msgs *mp,
                    && (!reedit || (status & 0x00ff))) {
                    if (!use && (status & 0xff00) &&
                            (rename (file, cp = m_backup (file)) != NOTOK)) {
                    && (!reedit || (status & 0x00ff))) {
                    if (!use && (status & 0xff00) &&
                            (rename (file, cp = m_backup (file)) != NOTOK)) {

-                       advise (NULL, "problems with edit--draft left in %s", cp);
+                       inform("problems with edit--draft left in %s", cp);

                    } else {
                    } else {

-                       advise (NULL, "problems with edit--%s preserved", file);
+                       inform("problems with edit--%s preserved", file);

                    }
                }
                status = -2;    /* maybe "reedit ? -2 : -1"? */
                    }
                }
                status = -2;    /* maybe "reedit ? -2 : -1"? */


@@ -812,7 +801,7 @@ static int
 sendfile (char **arg, char *file, int pushsw)
 {
     pid_t child_id;
 sendfile (char **arg, char *file, int pushsw)
 {
     pid_t child_id;

-    int i, vecp;
+    int vecp;

     char *cp, *sp, **vec, *program;
 
     /*
     char *cp, *sp, **vec, *program;
 
     /*


@@ -829,11 +818,11 @@ sendfile (char **arg, char *file, int pushsw)
     context_save ();   /* save the context file */
     fflush (stdout);
 
     context_save ();   /* save the context file */
     fflush (stdout);
 

-    for (i = 0; (child_id = fork()) == NOTOK && i < 5; i++)
-       sleep (5);
+    child_id = fork();

     switch (child_id) {
        case NOTOK:
     switch (child_id) {
        case NOTOK:

-           advise (NULL, "unable to fork, so sending directly...");
+           inform("unable to fork, so sending directly...");
+           /* FALLTHRU */

        case OK:
            vec = argsplit(sendproc, &program, &vecp);
            if (pushsw)
        case OK:
            vec = argsplit(sendproc, &program, &vecp);
            if (pushsw)


@@ -947,13 +936,12 @@ buildfile (char **argp, char *file)
     X("saslmech", SASLminc(5), SASLMECHSW) \
     X("authservice", SASLminc(0), AUTHSERVICESW) \
     X("user username", SASLminc(4), USERSW) \
     X("saslmech", SASLminc(5), SASLMECHSW) \
     X("authservice", SASLminc(0), AUTHSERVICESW) \
     X("user username", SASLminc(4), USERSW) \

-    X("attach fieldname", 6, SNDATTACHSW) \
-    X("noattach", 0, SNDNOATTACHSW) \
-    X("attachformat", 7, SNDATTACHFORMAT) \

     X("port server-port-name/number", 4, PORTSW) \
     X("tls", TLSminc(-3), TLSSW) \
     X("initialtls", TLSminc(-10), INITTLSSW) \
     X("notls", TLSminc(-5), NTLSSW) \
     X("port server-port-name/number", 4, PORTSW) \
     X("tls", TLSminc(-3), TLSSW) \
     X("initialtls", TLSminc(-10), INITTLSSW) \
     X("notls", TLSminc(-5), NTLSSW) \

+    X("certverify", TLSminc(-10), CERTVERSW) \
+    X("nocertverify", TLSminc(-12), NOCERTVERSW) \

     X("sendmail program", 0, MTSSM) \
     X("mts smtp|sendmail/smtp|sendmail/pipe", 2, MTSSW) \
     X("messageid localname|random", 2, MESSAGEIDSW) \
     X("sendmail program", 0, MTSSM) \
     X("mts smtp|sendmail/smtp|sendmail/pipe", 2, MTSSW) \
     X("messageid localname|random", 2, MESSAGEIDSW) \


@@ -1069,7 +1057,7 @@ sendit (char *sp, char **arg, char *file, int pushed)
                    ambigsw (cp, sendswitches);
                    return;
                case UNKWNSW:
                    ambigsw (cp, sendswitches);
                    return;
                case UNKWNSW:

-                   advise (NULL, "-%s unknown\n", cp);
+                   inform("-%s unknown\n", cp);

                    return;
 
                case SHELPSW:
                    return;
 
                case SHELPSW:


@@ -1089,7 +1077,7 @@ sendit (char *sp, char **arg, char *file, int pushed)
 
                case SPLITSW:
                    if (!(cp = *argp++) || sscanf (cp, "%d", &splitsw) != 1) {
 
                case SPLITSW:
                    if (!(cp = *argp++) || sscanf (cp, "%d", &splitsw) != 1) {

-                       advise (NULL, "missing argument to %s", argp[-2]);
+                       inform("missing argument to %s", argp[-2]);

                        return;
                    }
                    continue;
                        return;
                    }
                    continue;


@@ -1117,7 +1105,8 @@ sendit (char *sp, char **arg, char *file, int pushed)
                    continue;
 
                case DEBUGSW:
                    continue;
 
                case DEBUGSW:

-                   debugsw++;  /* fall */
+                   debugsw++;
+                   /* FALLTHRU */

                case NFILTSW:
                case FRMTSW:
                case NFRMTSW:
                case NFILTSW:
                case FRMTSW:
                case NFRMTSW:


@@ -1134,6 +1123,8 @@ sendit (char *sp, char **arg, char *file, int pushed)
                case TLSSW:
                case INITTLSSW:
                case NTLSSW:
                case TLSSW:
                case INITTLSSW:
                case NTLSSW:

+               case CERTVERSW:
+               case NOCERTVERSW:

                    vec[vecp++] = --cp;
                    continue;
 
                    vec[vecp++] = --cp;
                    continue;
 


@@ -1155,7 +1146,7 @@ sendit (char *sp, char **arg, char *file, int pushed)
 
                case SASLMECHSW:
                     saslmech = *argp;
 
                case SASLMECHSW:
                     saslmech = *argp;

-                   /* fall thru */
+                   /* FALLTHRU */

                case ALIASW:
                case FILTSW:
                case WIDTHSW:
                case ALIASW:
                case FILTSW:
                case WIDTHSW:


@@ -1168,7 +1159,7 @@ sendit (char *sp, char **arg, char *file, int pushed)
                case MESSAGEIDSW:
                    vec[vecp++] = --cp;
                    if (!(cp = *argp++) || *cp == '-') {
                case MESSAGEIDSW:
                    vec[vecp++] = --cp;
                    if (!(cp = *argp++) || *cp == '-') {

-                       advise (NULL, "missing argument to %s", argp[-2]);
+                       inform("missing argument to %s", argp[-2]);

                        return;
                    }
                    vec[vecp++] = cp;
                        return;
                    }
                    vec[vecp++] = cp;


@@ -1178,25 +1169,15 @@ sendit (char *sp, char **arg, char *file, int pushed)
                case SDRFSW:
                case SDRMSW:
                    if (!(cp = *argp++) || *cp == '-') {
                case SDRFSW:
                case SDRMSW:
                    if (!(cp = *argp++) || *cp == '-') {

-                       advise (NULL, "missing argument to %s", argp[-2]);
+                       inform("missing argument to %s", argp[-2]);

                        return;
                    }
                        return;
                    }

-               case SNDRFSW:
-                   continue;
-
-               case SNDATTACHSW:
-                   advise(NULL, "The -attach switch is deprecated");

                    continue;
                    continue;

-               case SNDNOATTACHSW:
-                   advise(NULL, "The -noattach switch is deprecated");
-                   continue;
-
-               case SNDATTACHFORMAT:
-                   advise(NULL, "The -attachformat switch is deprecated");
+               case SNDRFSW:

                    continue;
            }
        }
                    continue;
            }
        }

-       advise (NULL, "usage: %s [switches]", sp);
+       inform("usage: %s [switches]", sp);

        return;
     }
 
        return;
     }
 


@@ -1213,7 +1194,7 @@ sendit (char *sp, char **arg, char *file, int pushed)
 
     if ((cp = getenv ("SIGNATURE")) == NULL || *cp == 0)
        if ((cp = context_find ("signature")) && *cp)
 
     if ((cp = getenv ("SIGNATURE")) == NULL || *cp == 0)
        if ((cp = context_find ("signature")) && *cp)

-           m_putenv ("SIGNATURE", cp);
+           setenv("SIGNATURE", cp, 1);

 
     if ((annotext = getenv ("mhannotate")) == NULL || *annotext == 0)
        annotext = NULL;
 
     if ((annotext = getenv ("mhannotate")) == NULL || *annotext == 0)
        annotext = NULL;


@@ -1329,8 +1310,8 @@ static int
 checkmimeheader (char *drft)
 {
     FILE *f;
 checkmimeheader (char *drft)
 {
     FILE *f;

-    m_getfld_state_t gstate = 0;
-    char buf[BUFSIZ], name[NAMESZ];
+    m_getfld_state_t gstate;
+    char buf[NMH_BUFSIZ], name[NAMESZ];

     int state, retval = 0;
 
     if ((f = fopen(drft, "r")) == NULL) {
     int state, retval = 0;
 
     if ((f = fopen(drft, "r")) == NULL) {


@@ -1338,13 +1319,14 @@ checkmimeheader (char *drft)
        return (0);
     }
 
        return (0);
     }
 

+    gstate = m_getfld_state_init(f);

     for (;;) {
        int bufsz = sizeof(buf);
     for (;;) {
        int bufsz = sizeof(buf);

-       switch (state = m_getfld(&gstate, name, buf, &bufsz, f)) {
+       switch (state = m_getfld2(&gstate, name, buf, &bufsz)) {

        case FLD:
        case FLDPLUS:
            if (strcasecmp(name, VRSN_FIELD) == 0) {
        case FLD:
        case FLDPLUS:
            if (strcasecmp(name, VRSN_FIELD) == 0) {

-               advise(NULL, "Cannot use attach commands with already-"
+               inform("Cannot use attach commands with already-"

                       "formatted MIME message \"%s\"", drft);
                retval = 1;
                break;
                       "formatted MIME message \"%s\"", drft);
                retval = 1;
                break;