Added test of empty authorization code to test-mhlogin.

[nmh] / test / oauth / test-mhlogin

diff --git a/test/oauth/test-mhlogin b/test/oauth/test-mhlogin
index c6c026184fc4a38c5d9bdd75d091dc86eecde814..7454576b5c74653dffa0cd266de6a776f2fb1386 100755 (executable)
--- a/test/oauth/test-mhlogin
+++ b/test/oauth/test-mhlogin
@@ -18,7 +18,7 @@ expect_no_creds() {
 
 test_mhlogin() {
     start_fakehttp
 
 test_mhlogin() {
     start_fakehttp

-    run_test 'eval echo code | mhlogin -saslmech xoauth2 -authservice test' \
+    run_test 'eval echo code | mhlogin -saslmech xoauth2 -authservice test -user nobody@example.com' \

 "Load the following URL in your browser and authorize nmh to access test:
 
 http://127.0.0.1:${http_port}/oauth/auth?response_type=code&client_id=test-id&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&scope=test-scope
 "Load the following URL in your browser and authorize nmh to access test:
 
 http://127.0.0.1:${http_port}/oauth/auth?response_type=code&client_id=test-id&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&scope=test-scope


@@ -39,7 +39,7 @@ mhlogin: invalid response'
 #
 
 # TEST
 #
 
 # TEST

-echo 'mhlogin receives access and expiration'
+start_test 'mhlogin receives access and expiration'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -52,14 +52,14 @@ fake_json_response <<EOF
 EOF
 
 expect_creds <<EOF
 EOF
 
 expect_creds <<EOF

-access: test-access
-expire:
+access-nobody@example.com: test-access
+expire-nobody@example.com:

 EOF
 
 test_mhlogin
 
 # TEST
 EOF
 
 test_mhlogin
 
 # TEST

-echo 'mhlogin receives access and refresh'
+start_test 'mhlogin receives access and refresh'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -71,13 +71,13 @@ fake_json_response <<EOF
 EOF
 
 expect_creds <<EOF
 EOF
 
 expect_creds <<EOF

-access: test-access
+access-nobody@example.com: test-access

 EOF
 
 test_mhlogin
 
 # TEST
 EOF
 
 test_mhlogin
 
 # TEST

-echo 'mhlogin receives access, expiration, and refresh'
+start_test 'mhlogin receives access, expiration, and refresh'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -91,15 +91,15 @@ fake_json_response <<EOF
 EOF
 
 expect_creds <<EOF
 EOF
 
 expect_creds <<EOF

-access: test-access
-refresh: refresh-token
-expire:
+access-nobody@example.com: test-access
+refresh-nobody@example.com: refresh-token
+expire-nobody@example.com:

 EOF
 
 test_mhlogin
 
 # TEST
 EOF
 
 test_mhlogin
 
 # TEST

-echo 'mhlogin receives refresh only'
+start_test 'mhlogin receives refresh only'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -111,13 +111,13 @@ fake_json_response <<EOF
 EOF
 
 expect_creds <<EOF
 EOF
 
 expect_creds <<EOF

-refresh: refresh-token
+refresh-nobody@example.com: refresh-token

 EOF
 
 test_mhlogin
 
 # TEST
 EOF
 
 test_mhlogin
 
 # TEST

-echo 'mhlogin receives token_type only'
+start_test 'mhlogin receives token_type only'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -132,7 +132,7 @@ expect_no_creds
 test_mhlogin_invalid_response
 
 # TEST
 test_mhlogin_invalid_response
 
 # TEST

-echo 'mhlogin ignores extra bits in successful response JSON'
+start_test 'mhlogin ignores extra bits in successful response JSON'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -152,15 +152,65 @@ fake_json_response <<EOF
 EOF
 
 expect_creds <<EOF
 EOF
 
 expect_creds <<EOF

-access: test-access
-refresh: refresh-token
-expire:
+access-nobody@example.com: test-access
+refresh-nobody@example.com: refresh-token
+expire-nobody@example.com:

 EOF
 
 test_mhlogin
 
 # TEST
 EOF
 
 test_mhlogin
 
 # TEST

-echo 'mhlogin user enters bad code'
+start_test 'mhlogin multiple users'
+
+expect_http_post_code
+
+fake_json_response <<EOF
+{
+  "access_token": "user3-access",
+  "refresh_token": "user3-refresh",
+  "expires_in": 3600,
+  "token_type": "Bearer"
+}
+EOF
+
+expect_creds <<EOF
+access-nobody@example.com: user1-access
+refresh-nobody@example.com: user1-refresh
+expire-nobody@example.com:
+access-nobody2@example.com: user2-access
+refresh-nobody2@example.com: user2-refresh
+expire-nobody2@example.com:
+access-nobody3@example.com: user3-access
+refresh-nobody3@example.com: user3-refresh
+expire-nobody3@example.com:
+EOF
+
+fake_creds <<EOF
+access-nobody@example.com: user1-access
+refresh-nobody@example.com: user1-refresh
+expire-nobody@example.com: 100
+access-nobody2@example.com: user2-access
+refresh-nobody2@example.com: user2-refresh
+expire-nobody2@example.com: 100
+EOF
+
+start_fakehttp
+run_test 'eval echo code | mhlogin -saslmech xoauth2 -authservice test -user nobody3@example.com' \
+         "Load the following URL in your browser and authorize nmh to access test:
+
+http://127.0.0.1:${http_port}/oauth/auth?response_type=code&client_id=test-id&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&scope=test-scope
+
+Enter the authorization code: $1"
+check_http_req
+check_creds_private
+check_creds
+
+#
+# fail cases
+#
+
+# TEST
+start_test 'mhlogin user enters bad code'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -176,12 +226,8 @@ expect_no_creds
 
 test_mhlogin 'Code rejected; try again? '
 
 
 test_mhlogin 'Code rejected; try again? '
 

-#
-# fail cases
-#
-

 # TEST
 # TEST

-echo 'mhlogin response has no content-type'
+start_test 'mhlogin response has no content-type'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -199,7 +245,7 @@ expect_no_creds
 test_mhlogin_invalid_response
 
 # TEST
 test_mhlogin_invalid_response
 
 # TEST

-echo 'mhlogin JSON array'
+start_test 'mhlogin JSON array'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -212,7 +258,7 @@ expect_no_creds
 test_mhlogin_invalid_response
 
 # TEST
 test_mhlogin_invalid_response
 
 # TEST

-echo 'mhlogin JSON empty object'
+start_test 'mhlogin JSON empty object'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -225,7 +271,7 @@ expect_no_creds
 test_mhlogin_invalid_response
 
 # TEST
 test_mhlogin_invalid_response
 
 # TEST

-echo 'mhlogin empty response body'
+start_test 'mhlogin empty response body'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -237,7 +283,7 @@ expect_no_creds
 test_mhlogin_invalid_response
 
 # TEST
 test_mhlogin_invalid_response
 
 # TEST

-echo 'mhlogin gets proper error from http'
+start_test 'mhlogin gets proper error from http'

 
 expect_http_post_code
 
 
 expect_http_post_code
 


@@ -254,6 +300,31 @@ expect_no_creds
 test_mhlogin 'mhlogin: error exchanging code for OAuth2 token
 mhlogin: bad OAuth request; re-run with -snoop and send REDACTED output to nmh-workers'
 
 test_mhlogin 'mhlogin: error exchanging code for OAuth2 token
 mhlogin: bad OAuth request; re-run with -snoop and send REDACTED output to nmh-workers'
 

+# TEST
+start_test 'mhlogin -browser'
+
+run_test "eval echo code | mhlogin -saslmech xoauth2 -authservice test\
+ -user nobody@example.com -browser 'echo \$@ > ${MHTMPDIR}/$$.browser'" \
+"Follow the prompts in your browser to authorize nmh to access test.
+Enter the authorization code: mhlogin: error exchanging code for OAuth2 token
+mhlogin: error making HTTP request to OAuth2 authorization endpoint: Failed to connect to 127.0.0.1 port ${http_port}: Connection refused"
+
+cat > "${MHTMPDIR}/$$.browser.expected" <<EOF
+http://127.0.0.1:${http_port}/oauth/auth?response_type=code&client_id=test-id&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&scope=test-scope
+EOF
+check "${MHTMPDIR}/$$.browser" "${MHTMPDIR}/$$.browser.expected"
+
+# TEST
+start_test 'empty authorization code'
+run_test 'eval echo '' | mhlogin -saslmech xoauth2 -authservice test -user nobody@example.com' \
+         "Load the following URL in your browser and authorize nmh to access test:
+
+http://127.0.0.1:${http_port}/oauth/auth?response_type=code&client_id=test-id&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&scope=test-scope
+
+Enter the authorization code: Empty code; try again? "
+
+

 clean_fakehttp
 clean_fakehttp

+finish_test

 
 exit ${failed:-0}
 
 exit ${failed:-0}