utils.c: Improve comment describing add(). Suggest mh_xstrdup().

[nmh] / sbr / makedir.c

diff --git a/sbr/makedir.c b/sbr/makedir.c
index 562949bebafb249f83d80545a8d9547475db2594..9d5e12e537601cb17ca39334450f2974385f7100 100644 (file)
--- a/sbr/makedir.c
+++ b/sbr/makedir.c
@@ -1,6 +1,4 @@
-
-/*
- * makedir.c -- make a directory
+/* makedir.c -- make a directory
  *
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
@@ -12,16 +10,17 @@
  */
 
 #include <h/mh.h>
+#include "makedir.h"
 #include <sys/file.h>
 
 int
-makedir (char *dir)
+makedir (const char *dir)
 {
     char            path[PATH_MAX];
     char*           folder_perms_ASCII;
     int             had_an_error = 0;
     mode_t          folder_perms, saved_umask;
-    register char*  c;
+    char*  c;
 
     context_save();     /* save the context file */
     fflush(stdout);
@@ -45,7 +44,7 @@ makedir (char *dir)
     c = strncpy(path, dir, sizeof(path));
 
     while (!had_an_error && (c = strchr((c + 1), '/')) != NULL) {
-        *c = (char)0;
+        *c = '\0';
         if (access(path, X_OK)) {
             if (errno != ENOENT){
                 advise (dir, "unable to create directory");
@@ -73,6 +72,5 @@ makedir (char *dir)
 
     if (had_an_error)
         return 0;  /* opposite of UNIX error return convention */
-    else
-        return 1;
+    return 1;
 }