Don't `else' after return. Simplify control flow.

[nmh] / sbr / mf.c

diff --git a/sbr/mf.c b/sbr/mf.c
index e2da81d01b1e4802c2050912868c5a26f41e4248..9e5cad8ce8dcaa23cae22e00c0feede2dc407e59 100644 (file)
--- a/sbr/mf.c
+++ b/sbr/mf.c
@@ -34,17 +34,18 @@ isfrom(const char *string)
 int
 lequal (const char *a, const char *b)
 {
-    for (; *a; a++, b++)
+    char c1, c2;
+
+    for (; *a; a++, b++) {
        if (*b == 0)
            return FALSE;
-       else {
-           char c1 = islower ((unsigned char) *a) ?
-                                       toupper ((unsigned char) *a) : *a;
-           char c2 = islower ((unsigned char) *b) ?
-                                       toupper ((unsigned char) *b) : *b;
-           if (c1 != c2)
-               return FALSE;
-       }
+        c1 = islower ((unsigned char) *a) ?
+                                    toupper ((unsigned char) *a) : *a;
+        c2 = islower ((unsigned char) *b) ?
+                                    toupper ((unsigned char) *b) : *b;
+        if (c1 != c2)
+            return FALSE;
+    }
 
     return (*b == 0);
 }
@@ -258,7 +259,7 @@ getadrx (const char *addrs, int eai)
     while (isspace ((unsigned char) *ap))
        ap++;
     if (cp)
-       sprintf (adr, "%.*s", (int)(cp - ap), ap);
+       snprintf(adr, sizeof adr, "%.*s", (int)(cp - ap), ap);
     else
        strcpy (adr, ap);
     bp = adr + strlen (adr) - 1;
@@ -317,7 +318,7 @@ again: ;
            return OK;          /* why be choosy? */
 
        default: 
-           sprintf (err, "illegal address construct (%s)", buffer);
+           snprintf(err, sizeof err, "illegal address construct (%s)", buffer);
            return NOTOK;
     }
 
@@ -336,13 +337,13 @@ again: ;
                        return NOTOK;
                    if (last_lex == LX_RBRK)
                        return OK;
-                   sprintf (err, "missing right-bracket (%s)", buffer);
+                   snprintf(err, sizeof err, "missing right-bracket (%s)", buffer);
                    return NOTOK;
 
                case LX_COLN: 
            get_group: ;
                    if (glevel++ > 0) {
-                       sprintf (err, "nested groups not allowed (%s)", pers);
+                       snprintf(err, sizeof err, "nested groups not allowed (%s)", pers);
                        return NOTOK;
                    }
                    grp = add (": ", pers);
@@ -371,7 +372,7 @@ again: ;
                    goto more_phrase;
 
                default: 
-                   sprintf (err, "no mailbox in address, only a phrase (%s%s)",
+                   snprintf(err, sizeof err, "no mailbox in address, only a phrase (%s%s)",
                            pers, buffer);
                    return NOTOK;
            }
@@ -407,7 +408,7 @@ again: ;
                    return OK;
 
                default: 
-                   sprintf (err, "junk after local@domain (%s)", buffer);
+                   snprintf(err, sizeof err, "junk after local@domain (%s)", buffer);
                    return NOTOK;
            }
 
@@ -424,7 +425,7 @@ again: ;
            return OK;
 
        default: 
-           sprintf (err, "missing mailbox (%s)", buffer);
+           snprintf(err, sizeof err, "missing mailbox (%s)", buffer);
            return NOTOK;
     }
 }
@@ -472,7 +473,7 @@ route_addr (char *buffer)
            return OK;
 
        default: 
-           sprintf (err, "no at-sign after local-part (%s)", buffer);
+           snprintf(err, sizeof err, "no at-sign after local-part (%s)", buffer);
            return NOTOK;
     }
 }
@@ -491,7 +492,7 @@ local_part (char *buffer)
                break;
 
            default: 
-               sprintf (err, "no mailbox in local-part (%s)", buffer);
+               snprintf(err, sizeof err, "no mailbox in local-part (%s)", buffer);
                return NOTOK;
        }
 
@@ -518,7 +519,7 @@ domain (char *buffer)
                break;
 
            default: 
-               sprintf (err, "no sub-domain in domain-part of address (%s)", buffer);
+               snprintf(err, sizeof err, "no sub-domain in domain-part of address (%s)", buffer);
                return NOTOK;
        }
 
@@ -553,7 +554,7 @@ route (char *buffer)
                break;
 
            default: 
-               sprintf (err, "no sub-domain in domain-part of address (%s)", buffer);
+               snprintf(err, sizeof err, "no sub-domain in domain-part of address (%s)", buffer);
                return NOTOK;
        }
        switch (my_lex (buffer)) {
@@ -569,7 +570,7 @@ route (char *buffer)
                            break;
 
                        default: 
-                           sprintf (err, "no at-sign found for next domain in route (%s)",
+                           snprintf(err, sizeof err, "no at-sign found for next domain in route (%s)",
                                     buffer);
                    }
                    break;
@@ -586,7 +587,7 @@ route (char *buffer)
                return OK;
 
            default: 
-               sprintf (err, "no colon found to terminate route (%s)", buffer);
+               snprintf(err, sizeof err, "no colon found to terminate route (%s)", buffer);
                return NOTOK;
        }
     }
@@ -742,7 +743,7 @@ legal_person (const char *p)
     for (cp = p; *cp; cp++)
        for (i = 0; special[i].lx_chr; i++)
            if (*cp == special[i].lx_chr) {
-               sprintf (buffer, "\"%s\"", p);
+               snprintf(buffer, sizeof buffer, "\"%s\"", p);
                return buffer;
            }