Added check to get_file_info() in attach.c for failed fgets() call.

[nmh] / uip / new.c

diff --git a/uip/new.c b/uip/new.c
index 5efdf74c712aa87ba203775a79159678b1bb02d7..74d4d5122a91dcadecf65304eacbf9deaf831f45 100644 (file)
--- a/uip/new.c
+++ b/uip/new.c
@@ -13,10 +13,6 @@
 
 #include <sys/types.h>
 
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-
 #include <h/mh.h>
 #include <h/crawl_folders.h>
 #include <h/utils.h>
@@ -93,20 +89,35 @@ seq_in_list(char *name, char *sequences[])
 static char *
 get_msgnums(char *folder, char *sequences[])
 {
-    char *seqfile = concat(m_maildir(folder), "/", mh_seq, (void *)NULL);
-    FILE *fp = fopen(seqfile, "r");
+    char *seqfile = NULL;
+    FILE *fp;
     int state;
     char name[NAMESZ], field[BUFSIZ];
     char *cp;
     char *msgnums = NULL, *this_msgnums, *old_msgnums;
     m_getfld_state_t gstate = 0;
 
-    /* no sequences file -> no messages */
-    if (fp == NULL) {
-        return NULL;
+    /* copied from seq_read.c:seq_public */
+    /*
+     * If mh_seq == NULL or if *mh_seq == '\0' (the user has defined
+     * the "mh-sequences" profile entry, but left it empty),
+     * then just return, and do not initialize any public sequences.
+     */
+    if (mh_seq == NULL || *mh_seq == '\0')
+       return NULL;
+
+    /* get filename of sequence file */
+    seqfile = concat(m_maildir(folder), "/", mh_seq, (void *)NULL);
+
+    if (seqfile == NULL)
+       return NULL;
+
+    if ((fp = lkfopendata (seqfile, "r")) == NULL) {
+       free(seqfile);
+       return NULL;
     }
 
-    /* copied from seq_read.c:seq_public */
+    /* Use m_getfld to scan sequence file */
     for (;;) {
        int fieldsz = sizeof field;
        switch (state = m_getfld (&gstate, name, field, &fieldsz, fp)) {
@@ -167,7 +178,9 @@ get_msgnums(char *folder, char *sequences[])
     }
     m_getfld_state_destroy (&gstate);
 
-    fclose(fp);
+    lkfclosedata (fp, seqfile);
+
+    free(seqfile);
 
     return msgnums;
 }