Replace fprintf(fp, "%s", foo) with fputs(foo, fp).

[nmh] / sbr / folder_read.c

diff --git a/sbr/folder_read.c b/sbr/folder_read.c
index 170946b41ec351696a686da18bff73a2ae71869f..5b9f73f138f300314e1c243b0ec4de7b1dbf9642 100644 (file)
--- a/sbr/folder_read.c
+++ b/sbr/folder_read.c
@@ -25,9 +25,8 @@
 struct msgs *
 folder_read (char *name, int lockflag)
 {
 struct msgs *
 folder_read (char *name, int lockflag)
 {

-    int msgnum, prefix_len, len, *mi;
+    int msgnum, len, *mi;

     struct msgs *mp;
     struct msgs *mp;

-    struct stat st;

     struct dirent *dp;
     DIR *dd;
     bvector_t *v;
     struct dirent *dp;
     DIR *dd;
     bvector_t *v;


@@ -39,14 +38,8 @@ folder_read (char *name, int lockflag)
        return NULL;
     }
 
        return NULL;
     }
 

-    if (stat (name, &st) == -1) {
-       free (name);
-       return NULL;
-    }
-

     /* Allocate the main structure for folder information */
     /* Allocate the main structure for folder information */

-    mp = (struct msgs *) mh_xmalloc ((size_t) sizeof(*mp));
-
+    NEW(mp);

     clear_folder_flags (mp);
     mp->foldpath = name;
     mp->lowmsg = 0;
     clear_folder_flags (mp);
     mp->foldpath = name;
     mp->lowmsg = 0;


@@ -61,7 +54,6 @@ folder_read (char *name, int lockflag)
 
     if (access (name, W_OK) == -1)
        set_readonly (mp);
 
     if (access (name, W_OK) == -1)
        set_readonly (mp);

-    prefix_len = strlen(BACKUP_PREFIX);

 
     /*
      * Allocate a temporary place to record the
 
     /*
      * Allocate a temporary place to record the


@@ -107,7 +99,7 @@ folder_read (char *name, int lockflag)
 
                default: 
                    /* skip any files beginning with backup prefix */
 
                default: 
                    /* skip any files beginning with backup prefix */

-                   if (!strncmp (dp->d_name, BACKUP_PREFIX, prefix_len))
+                   if (HasPrefix(dp->d_name, BACKUP_PREFIX))

                        continue;
 
                    /* skip the LINK file */
                        continue;
 
                    /* skip the LINK file */


@@ -130,6 +122,16 @@ folder_read (char *name, int lockflag)
     /* for testing, allocate minimal necessary space */
     /* mp->hghoff = max (mp->hghmsg, 1); */
 
     /* for testing, allocate minimal necessary space */
     /* mp->hghoff = max (mp->hghmsg, 1); */
 

+    /*
+     * If for some reason hghoff < lowoff (like we got an integer overflow)
+     * the complain about this now.
+     */
+
+    if (mp->hghoff < mp->lowoff) {
+       adios(NULL, "Internal failure: high message limit < low message "
+             "limit; possible overflow?");
+    }
+

     /*
      * Allocate space for status of each message.
      */
     /*
      * Allocate space for status of each message.
      */


@@ -161,7 +163,15 @@ folder_read (char *name, int lockflag)
     /*
      * Read and initialize the sequence information.
      */
     /*
      * Read and initialize the sequence information.
      */

-    seq_read (mp, lockflag);
+    if (seq_read (mp, lockflag) == NOTOK) {
+        char seqfile[PATH_MAX];
+
+        /* Failed to lock sequence file. */
+        snprintf (seqfile, sizeof(seqfile), "%s/%s", mp->foldpath, mh_seq);
+        advise (seqfile, "failed to lock");
+
+        return NULL;
+    }

 
     return mp;
 }
 
     return mp;
 }