mhbuildsbr.c: Flip logic, moving goto to then-block; no need for else.

[nmh] / test / install-mh / test-version-check

diff --git a/test/install-mh/test-version-check b/test/install-mh/test-version-check
index eb27bf6a75feaec9156a96e4a484f17c42e85a0d..2db8565b0a85836727077259ab78128eba7f64f9 100755 (executable)
--- a/test/install-mh/test-version-check
+++ b/test/install-mh/test-version-check
@@ -17,17 +17,15 @@ fi
 
 setup_test
 
 
 setup_test
 

-require_prog script
-if script -S /bin/sh 'echo OK' /dev/null 2>&1 | egrep 'OK' >/dev/null; then
-    #### script(1) uses -S to set the shell that it runs.
-    use_dash_S=1
-else
-    #### Assume that script(1) uses SHELL environment variable.
-    use_dash_S=0
-fi
+actual="${MH_TEST_DIR}/test-version-check$$.actual"
+context="${MH_TEST_DIR}"/Mail/context
+version="Version: nmh-${MH_VERSION}"
+cmd="${MH_TEST_DIR}/Mail/cmd"
+runpty="${MH_OBJ_DIR}/test/runpty"

 
 

-#### Run a command but don't wait for user input.  script(1) seems to do
-#### what we want by not waiting when run in the background.
+#### Run a command but don't wait for user input.  We switched from script(1)
+#### to our own utility, runpty.  Check that it makes the command look like
+#### it's connected to a terminal below.

 run_without_input() {
     #### Create a command to use as a shell for script.
     cat >"${cmd}" <<EOF
 run_without_input() {
     #### Create a command to use as a shell for script.
     cat >"${cmd}" <<EOF


@@ -36,32 +34,27 @@ $*
 EOF
     chmod +x "${cmd}"
 
 EOF
     chmod +x "${cmd}"
 

-    if [ ${use_dash_S} -eq 1 ]; then
-        script -S "${cmd}" "$actual" >/dev/null &
-    else
-        SHELL="${cmd}" script "$actual" >/dev/null &
-    fi
-
-    wait $!
+    "$runpty" "${actual}" "${cmd}"

 }
 
 }
 

-actual="$MH_TEST_DIR/test-version-check$$.actual"
-context="${MH_TEST_DIR}"/Mail/context
-version="Version: nmh-${MH_VERSION}"
-cmd="${MH_TEST_DIR}/Mail/cmd"
+#### Ensure that runpty makes the program look like it's connected to a
+#### terminal.  The welcome message code in sbr/utils.c needs that.
+run_without_input 'if test -t 0  -a  -t 1  -a  -t 2; then echo tty; fi'
+grep tty "${actual}" >/dev/null || test_skip "runpty doesn't simulate tty"
+

 
 # Removing Version will trigger the welcome message.  (setup_test
 # inserted it so that other tests wouldn't show it.)
 
 # Removing Version will trigger the welcome message.  (setup_test
 # inserted it so that other tests wouldn't show it.)

-grep -v Version "$context" > "$context.NEW"
-mv -f "$context.NEW" "$context"
+grep -v Version "${context}" > "${context}.NEW"
+mv -f "${context}.NEW" "${context}"

 
 
 start_test 'mhparam skips the welcome message'
 run_without_input mhparam path
 
 
 start_test 'mhparam skips the welcome message'
 run_without_input mhparam path

-grep 'Welcome to nmh version ' "$actual" >/dev/null  &&  false
+grep 'Welcome to nmh version ' "${actual}" >/dev/null  &&  false

 # Make sure that version wasn't added to context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null  &&  false
 # Make sure that version wasn't added to context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null  &&  false

-rm "$actual"
+rm "${actual}"

 
 
 start_test 'Welcome: disable in profile skips the welcome message'
 
 
 start_test 'Welcome: disable in profile skips the welcome message'


@@ -73,59 +66,57 @@ printf 'Welcome: disable\n' >> "${MH}-welcome"
 # on the user's shell.
 (MH="${MH}-welcome"; run_without_input pick last)
 rm "${MH}-welcome"
 # on the user's shell.
 (MH="${MH}-welcome"; run_without_input pick last)
 rm "${MH}-welcome"

-grep 'Welcome to nmh version ' "$actual" >/dev/null  &&  false
+grep 'Welcome to nmh version ' "${actual}" >/dev/null  &&  false

 # Make sure that version wasn't added to context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null  &&  false
 # Make sure that version wasn't added to context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null  &&  false

-rm "$actual"
+rm "${actual}"

 
 
 start_test 'with welcome message'
 
 
 start_test 'with welcome message'

-echo MH="${MH}" # ???? debug

 run_without_input pick last
 run_without_input pick last

-cat "$actual" # ???? debug
-grep 'Welcome to nmh version ' "$actual" >/dev/null
+grep 'Welcome to nmh version ' "${actual}" >/dev/null

 # Make sure that version was added to context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null
 # Make sure that version was added to context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null

-rm "$actual"
+rm "${actual}"

 
 
 start_test 'without welcome message'
 # After running the previous test, this one should not have
 # the welcome message.
 run_without_input pick last
 
 
 start_test 'without welcome message'
 # After running the previous test, this one should not have
 # the welcome message.
 run_without_input pick last

-grep 'Welcome to nmh version ' "$actual" >/dev/null  &&  false
+grep 'Welcome to nmh version ' "${actual}" >/dev/null  &&  false

 # Make sure that version is still in context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null
 # Make sure that version is still in context.
 grep "^${version}$" "${MH_TEST_DIR}/Mail/context" >/dev/null

-rm "$actual"
+rm "${actual}"

 
 
 start_test 'with MHCONTEXT, welcome only if older'
 MHCONTEXT="${MH_TEST_DIR}/Mail/context2"; export MHCONTEXT
 printf 'Version: nmh-1.5\n' >"${MHCONTEXT}"
 run_without_input pick last
 
 
 start_test 'with MHCONTEXT, welcome only if older'
 MHCONTEXT="${MH_TEST_DIR}/Mail/context2"; export MHCONTEXT
 printf 'Version: nmh-1.5\n' >"${MHCONTEXT}"
 run_without_input pick last

-grep 'Welcome to nmh version ' "$actual" >/dev/null
+grep 'Welcome to nmh version ' "${actual}" >/dev/null

 # And make sure that version did get updated in context.
 grep "^${version}$" "${MHCONTEXT}" >/dev/null
 # And make sure that version did get updated in context.
 grep "^${version}$" "${MHCONTEXT}" >/dev/null

-rm "$actual"
+rm "${actual}"

 
 
 start_test "with MHCONTEXT doesn't welcome if newer"
 printf 'Version: nmh-10000.0\n' >"${MHCONTEXT}"
 run_without_input pick last
 
 
 start_test "with MHCONTEXT doesn't welcome if newer"
 printf 'Version: nmh-10000.0\n' >"${MHCONTEXT}"
 run_without_input pick last

-grep 'Welcome to nmh version ' "$actual" >/dev/null  &&  false
+grep 'Welcome to nmh version ' "${actual}" >/dev/null  &&  false

 # And make sure that version didn't get updated in context.
 grep '^Version: nmh-10000.0$' "${MHCONTEXT}" >/dev/null
 # And make sure that version didn't get updated in context.
 grep '^Version: nmh-10000.0$' "${MHCONTEXT}" >/dev/null

-rm "$actual"
+rm "${actual}"

 
 
 start_test 'with MHCONTEXT but no version, no welcome and update'
 printf '' >"${MHCONTEXT}"
 run_without_input pick last
 
 
 start_test 'with MHCONTEXT but no version, no welcome and update'
 printf '' >"${MHCONTEXT}"
 run_without_input pick last

-grep 'Welcome to nmh version ' "$actual" >/dev/null  &&  false
+grep 'Welcome to nmh version ' "${actual}" >/dev/null  &&  false

 # And make sure that version did get updated in context.
 grep "^${version}$" "${MHCONTEXT}" >/dev/null
 # And make sure that version did get updated in context.
 grep "^${version}$" "${MHCONTEXT}" >/dev/null

-rm "$actual"
+rm "${actual}"

 
 
 finish_test
 
 
 finish_test

-exit $failed
+exit ${failed}