X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/17932f7aea1c21cf17738f47996345d9d0a6ce51..fdc0a57327bb5887b08e5b2206fac5de2f821681:/sbr/folder_read.c diff --git a/sbr/folder_read.c b/sbr/folder_read.c index 02271bc6..73ffe431 100644 --- a/sbr/folder_read.c +++ b/sbr/folder_read.c @@ -27,9 +27,10 @@ folder_read (char *name, int lockflag) { int msgnum, prefix_len, len, *mi; struct msgs *mp; - struct stat st; struct dirent *dp; DIR *dd; + bvector_t *v; + size_t i; name = m_mailpath (name); if (!(dd = opendir (name))) { @@ -37,11 +38,6 @@ folder_read (char *name, int lockflag) return NULL; } - if (stat (name, &st) == -1) { - free (name); - return NULL; - } - /* Allocate the main structure for folder information */ mp = (struct msgs *) mh_xmalloc ((size_t) sizeof(*mp)); @@ -128,10 +124,26 @@ folder_read (char *name, int lockflag) /* for testing, allocate minimal necessary space */ /* mp->hghoff = max (mp->hghmsg, 1); */ + /* + * If for some reason hghoff < lowoff (like we got an integer overflow) + * the complain about this now. + */ + + if (mp->hghoff < mp->lowoff) { + adios(NULL, "Internal failure: high message limit < low message " + "limit; possible overflow?"); + } + /* * Allocate space for status of each message. */ - mp->msgstats = mh_xmalloc (MSGSTATSIZE(mp, mp->lowoff, mp->hghoff)); + mp->num_msgstats = MSGSTATNUM (mp->lowoff, mp->hghoff); + mp->msgstats = mh_xmalloc (MSGSTATSIZE(mp)); + for (i = 0, v = mp->msgstats; i < mp->num_msgstats; ++i, ++v) { + *v = bvector_create (0); + } + + mp->msgattrs = svector_create (0); /* * Clear all the flag bits for all the message @@ -153,7 +165,15 @@ folder_read (char *name, int lockflag) /* * Read and initialize the sequence information. */ - seq_read (mp, lockflag); + if (seq_read (mp, lockflag) == NOTOK) { + char seqfile[PATH_MAX]; + + /* Failed to lock sequence file. */ + snprintf (seqfile, sizeof(seqfile), "%s/%s", mp->foldpath, mh_seq); + advise (seqfile, "failed to lock"); + + return NULL; + } return mp; }