X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/3b6be5607a251a3a793e97382e251ce66ea2bca0..06d294bec2a41d0f6bbbf77d927292ada9464ced:/sbr/ext_hook.c

diff --git a/sbr/ext_hook.c b/sbr/ext_hook.c
index a86e7a3f..186f77c3 100644
--- a/sbr/ext_hook.c
+++ b/sbr/ext_hook.c
@@ -22,10 +22,10 @@ ext_hook(char *hook_name, char *message_file_name_1, char *message_file_name_2)
 
     static  int	did_message = 0;	/* set if we've already output a message */
 
-    if ((hook = context_find(hook_name)) == (char *)0)
+    if ((hook = context_find(hook_name)) == NULL)
 	return (OK);
 
-    switch (pid = vfork()) {
+    switch (pid = fork()) {
     case -1:
 	status = NOTOK;
 	advise(NULL, "external database may be out-of-date.");
@@ -37,6 +37,7 @@ ext_hook(char *hook_name, char *message_file_name_1, char *message_file_name_2)
 	vec[vecp++] = message_file_name_2;
 	vec[vecp++] = NULL;
 	execvp(program, vec);
+	advise(program, "Unable to execute");
 	_exit(-1);
 	/* NOTREACHED */
 
@@ -47,11 +48,14 @@ ext_hook(char *hook_name, char *message_file_name_1, char *message_file_name_2)
 
     if (status != OK) {
 	if (did_message == 0) {
-	    if ((hook = context_find("msg-hook")) != (char *)0)
-		advise(NULL, hook);
-	    else
-		advise(NULL, "external hook (%s) did not work properly.", hook);
-	
+	    char *msghook;
+	    if ((msghook = context_find("msg-hook")) != NULL)
+		advise(NULL, msghook);
+	    else {
+	    	char errbuf[BUFSIZ];
+		snprintf(errbuf, sizeof(errbuf), "external hook \"%s\"", hook);
+		pidstatus(status, stderr, errbuf);
+	    }
 	    did_message = 1;
 	}