X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/3b6be5607a251a3a793e97382e251ce66ea2bca0..af32d40a8ca0b341c082066b2f1e3e83005c1a89:/sbr/ext_hook.c

diff --git a/sbr/ext_hook.c b/sbr/ext_hook.c
index a86e7a3f..106114f8 100644
--- a/sbr/ext_hook.c
+++ b/sbr/ext_hook.c
@@ -1,6 +1,4 @@
-/*
- *
- *	Run a program that hooks into some other system.  The first argument is
+/*	Run a program that hooks into some other system.  The first argument is
  *	name of the hook to use, the second is the full path name of a mail message.
  *	The third argument is also the full path name of a mail message, or a NULL
  *	pointer if it isn't needed.  Look in the context for an error message if
@@ -8,7 +6,11 @@
  *	Only produce the error message once.
  */
 
-#include <h/mh.h>
+#include "h/mh.h"
+#include "context_find.h"
+#include "pidstatus.h"
+#include "arglist.h"
+#include "error.h"
 
 int
 ext_hook(char *hook_name, char *message_file_name_1, char *message_file_name_2)
@@ -20,15 +22,15 @@ ext_hook(char *hook_name, char *message_file_name_1, char *message_file_name_2)
     int		vecp;			/* Vector index */
     char 	*program;		/* Name of program to execute */
 
-    static  int	did_message = 0;	/* set if we've already output a message */
+    static bool	did_message;            /* set if we've already output a message */
 
-    if ((hook = context_find(hook_name)) == (char *)0)
-	return (OK);
+    if ((hook = context_find(hook_name)) == NULL)
+	return OK;
 
-    switch (pid = vfork()) {
+    switch (pid = fork()) {
     case -1:
 	status = NOTOK;
-	advise(NULL, "external database may be out-of-date.");
+	inform("external database may be out-of-date.");
 	break;
 
     case 0:
@@ -37,7 +39,8 @@ ext_hook(char *hook_name, char *message_file_name_1, char *message_file_name_2)
 	vec[vecp++] = message_file_name_2;
 	vec[vecp++] = NULL;
 	execvp(program, vec);
-	_exit(-1);
+	advise(program, "Unable to execute");
+	_exit(1);
 	/* NOTREACHED */
 
     default:
@@ -45,19 +48,20 @@ ext_hook(char *hook_name, char *message_file_name_1, char *message_file_name_2)
 	break;
     }
 
-    if (status != OK) {
-	if (did_message == 0) {
-	    if ((hook = context_find("msg-hook")) != (char *)0)
-		advise(NULL, hook);
-	    else
-		advise(NULL, "external hook (%s) did not work properly.", hook);
-	
-	    did_message = 1;
-	}
-
-	return (NOTOK);
+    if (status == OK)
+	return OK;
+
+    if (!did_message) {
+        char *msghook;
+        if ((msghook = context_find("msg-hook")) != NULL)
+            inform("%s", msghook);
+        else {
+            char errbuf[BUFSIZ];
+            snprintf(errbuf, sizeof(errbuf), "external hook \"%s\"", hook);
+            pidstatus(status, stderr, errbuf);
+        }
+        did_message = true;
     }
 
-    else
-	return (OK);
+    return NOTOK;
 }