X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/5774466bc16c2e12e36b6f050fbec8bc60913eb7..4e8e2c96547bfe72589982a85fac450df4cf6d08:/sbr/utils.c?ds=sidebyside diff --git a/sbr/utils.c b/sbr/utils.c index ff144673..d27fa81d 100644 --- a/sbr/utils.c +++ b/sbr/utils.c @@ -346,8 +346,33 @@ nmh_strcasestr (const char *s1, const char *s2) { } -/* HasPrefix returns true if non-NULL s starts with non-NULL prefix. */ -bool HasPrefix(const char *s, const char *prefix) +/* truncpy copies at most size - 1 chars from non-NULL src to non-NULL, + * non-overlapping, dst, and ensures dst is NUL terminated. If size is + * zero then it aborts as dst cannot be NUL terminated. + * + * It's to be used when truncation is intended and correct, e.g. + * reporting a possibly very long external string back to the user. One + * of its advantages over strncpy(3) is it doesn't pad in the common + * case of no truncation. */ +void trunccpy(char *dst, const char *src, size_t size) +{ + if (!size) { + advise(NULL, "trunccpy: zero-length destination: \"%.20s\"", + src ? src : "null"); + abort(); + } + + if (strnlen(src, size) < size) { + strcpy(dst, src); + } else { + memcpy(dst, src, size - 1); + dst[size - 1] = '\0'; + } +} + + +/* has_prefix returns true if non-NULL s starts with non-NULL prefix. */ +bool has_prefix(const char *s, const char *prefix) { while (*s && *s == *prefix) { s++; @@ -358,8 +383,8 @@ bool HasPrefix(const char *s, const char *prefix) } -/* HasSuffix returns true if non-NULL s ends with non-NULL suffix. */ -bool HasSuffix(const char *s, const char *suffix) +/* has_suffix returns true if non-NULL s ends with non-NULL suffix. */ +bool has_suffix(const char *s, const char *suffix) { size_t ls, lsuf; @@ -370,17 +395,17 @@ bool HasSuffix(const char *s, const char *suffix) } -/* HasSuffixC returns true if non-NULL string s ends with a c before the +/* has_suffix_c returns true if non-NULL string s ends with a c before the * terminating NUL. */ -bool HasSuffixC(const char *s, int c) +bool has_suffix_c(const char *s, int c) { return *s && s[strlen(s) - 1] == c; } -/* TrimSuffixC deletes c from the end of non-NULL string s if it's +/* trim_suffix_c deletes c from the end of non-NULL string s if it's * present, shortening s by 1. Only one instance of c is removed. */ -void TrimSuffixC(char *s, int c) +void trim_suffix_c(char *s, int c) { if (!*s) return; @@ -391,8 +416,8 @@ void TrimSuffixC(char *s, int c) } -/* ToLower runs all of s through tolower(3). */ -void ToLower(char *s) +/* to_lower runs all of s through tolower(3). */ +void to_lower(char *s) { unsigned char *b; @@ -401,8 +426,8 @@ void ToLower(char *s) } -/* ToUpper runs all of s through toupper(3). */ -void ToUpper(char *s) +/* to_upper runs all of s through toupper(3). */ +void to_upper(char *s) { unsigned char *b; @@ -502,7 +527,7 @@ nmh_version_changed (int older) { break for versions with multiple decimal points, etc. */ const float current_version = strtof (VERSION, NULL); const float old_version = - context_version && HasPrefix(context_version, "nmh-") + context_version && has_prefix(context_version, "nmh-") ? strtof (context_version + 4, NULL) : 99999999; @@ -528,7 +553,7 @@ char * upcase (const char *str) { char *up = cpytrim (str); - ToUpper(up); + to_upper(up); return up; }