X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/5ee3667d7daf6e7090e3de104c3679259eb26da5..605516b7c2e68efcd681478d40b210e6af968d58:/docs/README.developers diff --git a/docs/README.developers b/docs/README.developers index af384124..d834b5e9 100644 --- a/docs/README.developers +++ b/docs/README.developers @@ -6,26 +6,66 @@ This file is intended to provide a few tips for anyone doing development on nmh. Developers who learn things "the hard way" about the nmh codebase (as opposed to local info best encoded in a comment) are encouraged to share their wisdom here. -The topics are organized alphabetically. - - --------------- -autoconf files --------------- - -If you wish to change the `configure' script or its related files, you'll need -to first install GNU m4, available from and then -GNU autoconf (). Nmh is currently using -a minimum of autoconf 2.61. - -Most of the configure-related files are automatically generated. The only files -you should need to manually edit are acconfig.h and configure.in. Don't, for -instance, edit config.h.in. Though it is an input file from the point of view -of the users (and the configure script) it is an output file from the point of -view of the developers (and the autoconf script). - -Note that the automatically generated autoconf files (such as config.h.in, -stamp-h.in, and configure), are NOT kept in git. Thus, when you check out +Following a commit checklist, the topics are organized alphabetically. + + +---------------- +commit checklist +---------------- + +1. code updated? +2. test added? +3. make distcheck passed? +4. man page and other documentation updated? +5. docs/pending-release-notes updated? +6. should commit message reference bug report? +7. update/close bug report (with commit id)? +8. notify nmh-users? + +A buildbot at http://orthanc.ca:8010/waterfall polls for new commits and +builds them on a few platforms. Keep an eye on its progress in case +you've committed something non-portable. (If you can provide another +platform, contact the nmh-workers list.) + + +--------------------------------- +C library/system call usage notes +--------------------------------- + +* Use m_mktemp2() or m_mktemp() instead of mkstemp(3) (see section on + nmh temporary files below). +* Use m_unlink() instead of unlink(3). +* Use done() instead of _exit(3) except after a fork(3). + + +------------------------- +autoconf & automake files +------------------------- + +If you wish to change the `configure' script, the generated Makefile +or other related files, you'll need to first install GNU m4, available +from , then GNU autoconf +() and GNU automake +(). Nmh is currently using a +minimum of autoconf 2.68 and automake 1.12. + +Most of the configure-related files are automatically generated. +The only files you should need to manually edit are configure.ac +and any autoconf macros in the m4 directory. Don't, for instance, +edit config.h.in. Though it is an input file from the point of +view of the users (and the configure script) it is an output file +from the point of view of the developers (and the autoconf script). + +If you wish to add a new autoconf macro, it should be placed in it's +own file and put in the m4 directory; aclocal will automatically pick +it up and automake will add it to the distribution target automatically. + +If you wish to make changes to the Makefile, you will need to edit +Makefile.am. See the automake documentation if you need further help. +You should always check changes to Makefile.am by using "make distcheck". + +Note that the automatically generated autotools files (such as config.h.in, +Makefile.in, and configure), are NOT kept in git. Thus, when you check out a git tree, you need to run the autogen.sh script before you can build anything: @@ -78,9 +118,16 @@ sbr/ file. These functions are of general use and are called from throughout nmh. +SPECS/ + Contains files such as RPM specs. + test/ The num unit test suite. +tools/ + "tools" contains tools, scripts, and supporting files used by the + developers while writing, debugging, and testing the code. + uip/ "uip" stands for "User Interface Programs". Most nmh commands have a file in this directory named .c containing the code for that command @@ -96,15 +143,33 @@ git As of December 2010, nmh has switched to using git for revision control instead of CVS. While the topic of git is beyond the scope of this FAQ, to get started with git & nmh, you can run the following command to checkout -the nmh repository: +the nmh repository (with read-only access to it): % git clone git://git.savannah.nongnu.org/nmh.git -That will create a workspace call nmh. To update that workspace +That will create a workspace called nmh. To update that workspace with changes to the master, cd to it and run: % git pull +If you are a project member and want write access to the repository, +you'll have to checkout with the following command instead of the one +above: + + % git clone @git.sv.nongnu.org:/srv/git/nmh.git + +We suggest using git pull --rebase instead of the default merge for +git pull. If you don't want to add the --rebase option every time, +you can tell git pull to always rebase in your nmh workspace by +cd'ing to it and running the following command: + + % git config --bool branch.master.rebase true + +And you'll probably want the following, also, so that --rebase applies +to any new branches that you create: + + % git config branch.autosetuprebase always + ------------------------------------------------------- nmh-local functions to use in preference to OS versions @@ -121,77 +186,119 @@ OS function nmh-local version to use instead getpass() nmh_getpass() +------------------- +nmh temporary files +------------------- + +To create a temporary file, use m_mktemp2() or m_mktemp(). They use +mkstemp(3), but they also register the temporary file for removal on +program termination. So, do not use mkstemp() directly. + +To further support this, nmh_init() must be called at the beginning of +main(). And, if a child process is not going to immediately call one +of the exec(3) functions or _exit(3) after a fork(3), it should call +unregister_for_removal(0). Finally, nmh_init() sets up signal handlers +for several signals: these signal handlers should not be disabled. + + +-------------- +nmh test suite +-------------- + +The nmh test suite is run through the Makefile, with "make check" +or "make distcheck". + +In the nmh test suite, nmh programs to be tested should be invoked +through the run_test or run_prog shell functions defined in +test/common.sh. + +Instead of echoing test progress, use start_test()/finish_test() +from tests/common.sh. These will report the particular test name, +within the test, only if there is a failure. + +To enable the use of valgrind, where available, set the environment +variable NMH_VALGRIND to a non-null value. However, a separate +environment variable, VALGRIND_ME, triggers the use of valgrind in +test/inc/test-eom-align because it greatly extends the duration of +that test. + +If valgrind complains about "serious error when reading debuginfo" +from a library, either update or remove the debuginfo package for +the offending library. + + ------------- releasing nmh ------------- -To make a public release of nmh (we'll use version 1.0.4 and my mhost.com -account, danh, as examples here; the convention for release candidates -is to use something like "1.0.4-RC1"): +To make a public release of nmh (we'll use version 1.5 as the example +here; the convention for release candidates is to use something like +"1.5-RC1"): - 1. % echo 1.0.4 > VERSION - % date +"%e %B %Y" > DATE - (DATE should contain something like "30 December 2000") + 1. Create a release branch. The convention is to name release branches + with the name "-release". - 2. % git commit VERSION DATE; git push + % git branch 1.5-release - 3. % git tag -a nmh-1_0_4 -m 'Releasing nmh-1_0_4.' + Note you are still on the master branch at this point. Mark the + current revision as the branchpoint for the new release branch: - 4. % make nmhdist + % git tag -a -m "This tag marks the point where we started the branch for 1.5" 1.5-branchpoint - 5. Untar nmh-1.0.4.tar.gz and `diff -r' it vs. your workspace. Make - sure no files got left out of the distribution that should be in - it (due to someone forgetting to update the DIST variables in the - Makefiles). + Now mark the master branch with a post-release version number (the + convention here is to use VERSION+dev as the version number). - 6. If you have root access on your machine, it's good at this point to do: + % echo 1.5+dev > VERSION + % git commit VERSION + % git push + % git push --tags - % chown -R 0:0 nmh-1.0.4 - % tar cvf nmh-1.0.4.tar nmh-1.0.4 - % gzip nmh-1.0.4.tar + Then do: - If you leave the files in the archive as being owned by yourself, your UID - may coincide with one of a user on a machine where nmh is being installed, - making it possible for that user to Trojan the nmh code before the system - administrator finishes installing it. + % git checkout 1.5-release - 7. Make sure your new tarball uncompresses and untars with no problem. Make - sure you can configure, make, and install nmh from it. + You are now on the 1.5 release branch. - 8. If all is well and your tarball is final, go back to your workspace and do: + 2. % echo 1.5 > VERSION + % date +"%e %B %Y" > DATE + (DATE should contain something like "30 December 2000") + + 3. % git commit VERSION DATE; git push + + 4. % git tag -a 1.5 -m 'Releasing nmh-1.5.' + % git push --tags + + Note that the new convention for tagging is to simply tag with the + version number (tag formats in the past have varied). - % echo 1.0.4+dev > VERSION + 5. % make distcheck - 9. % git commit VERSION; git push + If you want to check the distribution build with some particular + configure options, set the DISTCHECK_CONFIGURE_FLAGS variable. + E.g.: -10. If possible, make an MD5 hash and/or a PGP signature of nmh-1.0.4.tar.gz. - Assuming you have gpg set up, this should be: - % gpg --output nmh-1.0.4.tar.gz.sig --detach-sig nmh-1.0.4.tar.gz + % make distcheck DISTCHECK_CONFIGURE_FLAGS=--with-cyrus-sasl - You can verify the signature with - % gpg --verify nmh-1.0.4.tar.gz.sig nmh-1.0.4.tar.gz + 6. Upload the distribution file to savannah. You can automate this process + by doing: -11. Upload the files to savannah. First make sure they are mode 664 so - they will have the right permissions on the server end - (see https://savannah.gnu.org/maintenance/SharedDownloadArea) - % chmod 664 nmh-1.0.4.tar.gz* + % make upload SAVANNAH_USERNAME=username - Then scp them across: - % scp -p nmh-1.0.4.tar.gz* youruser@dl.sv.nongnu.org:/releases/nmh/ + This will automatically call gpg to sign the release. You can bypass + this step by setting the SKIP_GPG_SIG variable. -12. Update the http://www.nongnu.org/nmh/ homepage. (It lives in the CVS + 7. Update the http://www.nongnu.org/nmh/ homepage. (It lives in the CVS 'webpages repository'; see https://savannah.nongnu.org/cvs/?group=nmh) -13. Add a news item to the savannah nmh page. You'll have to submit it first + 8. Add a news item to the savannah nmh page. You'll have to submit it first and then separately approve it (under News->Manage). -14. Send the release announcement email to the following places: + 9. Send the release announcement email to the following places: nmh-workers@nongnu.org nmh-announce@nongnu.org exmh-users@redhat.com exmh-workers@redhat.com mh-e-users@lists.sourceforge.net - mh-users@ics.uci.edu *or* comp.mail.mh (there is a bidirectional gateway) If the release fixes significant security holes, also send an announcement to bugtraq@securityfocus.com. The exmh lists require you to be subscribed @@ -208,3 +315,19 @@ is to use something like "1.0.4-RC1"): it assumes that we tag with nmh-x_x-release from now on]: http://git.savannah.gnu.org/cgit/nmh.git/diff/?h=nmh-1_5-release?h=nmh-1_4-release + + +--------------- +after a release +--------------- + +Keep an eye on Debian's packaging, especially what patches they have to +apply, and the results of their Lintian checker, which even includes +spelling errors in man pages and binaries. + + https://sources.debian.net/src/nmh/1.6-16/debian/patches/ + https://lintian.debian.org/full/az@debian.org.html#nmh + +Perhaps some nmh developer that uses Debian, or Ubuntu?, could provide +package-building commands, including lintian(1), for Makefile.am so +Lintian's complaints are known before release.