X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/8890670d4c1e8e3f9608c2850c1fe299fb256776..8699f1cc:/uip/burst.c?ds=sidebyside

diff --git a/uip/burst.c b/uip/burst.c
index c156076a..5e5d86b9 100644
--- a/uip/burst.c
+++ b/uip/burst.c
@@ -1,6 +1,4 @@
-
-/*
- * burst.c -- explode digests into individual messages
+/* burst.c -- explode digests into individual messages
  *
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
@@ -10,6 +8,10 @@
 #include <h/mh.h>
 #include <h/utils.h>
 #include <h/mhparse.h>
+#include "h/done.h"
+#include "sbr/m_maildir.h"
+#include "sbr/m_mktemp.h"
+#include "mhfree.h"
 
 #define BURST_SWITCHES \
     X("inplace", 0, INPLSW) \
@@ -132,8 +134,7 @@ main (int argc, char **argv)
 	if (*cp == '+' || *cp == '@') {
 	    if (folder)
 		adios (NULL, "only one folder at a time!");
-	    else
-		folder = pluspath (cp);
+            folder = pluspath (cp);
 	} else {
 	    app_msgarg(&msgs, cp);
 	}
@@ -174,13 +175,13 @@ main (int argc, char **argv)
 	    if ((numburst = find_delim (msgnum, smsgs, &mimesw)) >= 1) {
 		if (verbosw)
 		    printf ("%d message%s exploded from digest %d\n",
-			    numburst, numburst > 1 ? "s" : "", msgnum);
+			    numburst, PLURALS(numburst), msgnum);
 		burst (&mp, msgnum, smsgs, numburst, inplace, verbosw,
 		       maildir, mimesw);
 	    } else {
 		if (numburst == 0) {
 		    if (!quietsw)
-			admonish (NULL, "message %d not in digest format",
+			inform("message %d not in digest format, continuing...",
 				  msgnum);
 		}  /* this pair of braces was missing before 1999-07-15 */
 		else
@@ -189,7 +190,7 @@ main (int argc, char **argv)
 	}
     }
 
-    free ((char *) smsgs);
+    free(smsgs);
     context_replace (pfolder, folder);	/* update current folder */
 
     /*
@@ -242,17 +243,17 @@ find_delim (int msgnum, struct smsg *smsgs, int *mimesw)
     	content = parse_mime(msgnam);
 	if (! content && *mimesw == 2)
 	    return 0;
-	else if (content) {
+	if (content) {
 	    smsgs[0].s_start = 0;
 	    smsgs[0].s_stop = content->c_begin - 1;
 	    msgp = 1;
 	    find_mime_parts(content, smsgs, &msgp);
 	    free_content(content);
-	    if (msgp == 1 && *mimesw == 2) {
+	    if (msgp == 1 && *mimesw == 2)
 	    	adios (msgnam, "does not have any message/rfc822 parts");
-	    } else if (msgp > 1) {
+	    if (msgp > 1) {
 	    	*mimesw = 1;
-		return (msgp - 1);
+		return msgp - 1;
 	    }
 	}
     }
@@ -292,8 +293,7 @@ find_delim (int msgnum, struct smsg *smsgs, int *mimesw)
 	for (c = 0; fgets (buffer, sizeof(buffer), in); c = buffer[0]) {
 	    if ((wasdlm = CHECKDELIM(buffer)))
 		break;
-	    else
-		pos += (long) strlen (buffer);
+            pos += (long) strlen (buffer);
 	}
 
 	/*
@@ -316,7 +316,7 @@ find_delim (int msgnum, struct smsg *smsgs, int *mimesw)
     }
 
     fclose (in);
-    return (msgp - 1);		/* return the number of messages burst */
+    return msgp - 1;		/* return the number of messages burst */
 }
 
 
@@ -353,8 +353,6 @@ find_mime_parts (CT content, struct smsg *smsgs, int *msgp)
 	for (part = m->mp_parts; part; part = part->mp_next)
 	    find_mime_parts(part->mp_part, smsgs, msgp);
     }
-
-    return;
 }
 
 
@@ -478,13 +476,13 @@ burst (struct msgs **mpp, int msgnum, struct smsg *smsgs, int numburst,
 		admonish (f3, "unable to rename %s to", f1);
 
 	    (void)snprintf(f3, sizeof (f3), "%s/%d", maildir, i);
-	    ext_hook("del-hook", f3, (char *)0);
+	    ext_hook("del-hook", f3, NULL);
 	}
 	if (rename (f2, f1) == NOTOK)
 	    admonish (f1, "unable to rename %s to", f2);
 
 	(void)snprintf(f3, sizeof (f3), "%s/%d", maildir, i);
-	ext_hook("add-hook", f3, (char *)0);
+	ext_hook("add-hook", f3, NULL);
 
 	copy_msg_flags (mp, i, msgnum);
 	mp->msgflags |= SEQMOD;
@@ -507,7 +505,7 @@ burst (struct msgs **mpp, int msgnum, struct smsg *smsgs, int numburst,
 static void
 cpybrst (FILE *in, FILE *out, char *ifile, char *ofile, int len, int mime)
 {
-    register int c, state;
+    int c, state;
 
     for (state = mime ? S4 : S1; (c = fgetc (in)) != EOF && len > 0; len--) {
 	if (c == 0)
@@ -521,6 +519,7 @@ cpybrst (FILE *in, FILE *out, char *ifile, char *ofile, int len, int mime)
 
 		    default: 
 			state = S2;
+			/* FALLTHRU */
 		    case '\n': 
 			fputc (c, out);
 			break;
@@ -531,6 +530,7 @@ cpybrst (FILE *in, FILE *out, char *ifile, char *ofile, int len, int mime)
 		switch (c) {
 		    case '\n': 
 			state = S1;
+			/* FALLTHRU */
 		    default: 
 			fputc (c, out);
 			break;