X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/8bb0f8000b86df9270f2410de3fb6f41fa63e88b..821f3da0f61239ec5990c105e77aacc7638e45eb:/uip/replsbr.c

diff --git a/uip/replsbr.c b/uip/replsbr.c
index d81eb745..eff1877e 100644
--- a/uip/replsbr.c
+++ b/uip/replsbr.c
@@ -69,8 +69,7 @@ replout (FILE *inb, char *msg, char *drft, struct msgs *mp, int outputlinelen,
     struct format *fmt;
     register char **ap;
     int	char_read = 0, format_len, mask;
-    char name[NAMESZ], *scanl;
-    unsigned char *cp;
+    char name[NAMESZ], *scanl, *cp;
     static int dat[5];			/* aux. data for format routine */
     m_getfld_state_t gstate = 0;
 
@@ -172,12 +171,12 @@ replout (FILE *inb, char *msg, char *drft, struct msgs *mp, int outputlinelen,
 		adios (NULL, "m_getfld() returned %d", state);
 	}
     }
-    m_getfld_state_destroy (&gstate);
 
     /*
      * format and output the header lines.
      */
 finished:
+    m_getfld_state_destroy (&gstate);
 
     /*
      * if there's a "Subject" component, strip any "Re:"s off it
@@ -187,7 +186,7 @@ finished:
 	register char *sp = cp;
 
 	for (;;) {
-	    while (isspace(*cp))
+	    while (isspace((unsigned char) *cp))
 		cp++;
 	    if(uprf(cp, "re:"))
 		cp += 3;
@@ -412,7 +411,8 @@ replfilter (FILE *in, FILE *out, char *filter, int fmtproc)
     int	pid;
     char *mhl;
     char *errstr;
-    char *arglist[7];
+    char **arglist;
+    int argnum;
 
     if (filter == NULL)
 	return;
@@ -420,12 +420,10 @@ replfilter (FILE *in, FILE *out, char *filter, int fmtproc)
     if (access (filter, R_OK) == NOTOK)
 	adios (filter, "unable to read");
 
-    mhl = r1bindex (mhlproc, '/');
-
     rewind (in);
     lseek (fileno(in), (off_t) 0, SEEK_SET);
 
-    switch (pid = vfork()) {
+    switch (pid = fork()) {
 	case NOTOK: 
 	    adios ("fork", "unable to");
 
@@ -434,26 +432,29 @@ replfilter (FILE *in, FILE *out, char *filter, int fmtproc)
 	    dup2 (fileno (out), fileno (stdout));
 	    closefds (3);
 
-	    arglist[0] = mhl;
-	    arglist[1] = "-form";
-	    arglist[2] = filter;
-	    arglist[3] = "-noclear";
+	    /*
+	     * We're not allocating the memory for the extra arguments,
+	     * because we never call arglist_free().  But if we ever change
+	     * that be sure to use getcpy() for the extra arguments.
+	     */
+	    arglist = argsplit(mhlproc, &mhl, &argnum);
+	    arglist[argnum++] = "-form";
+	    arglist[argnum++] = filter;
+	    arglist[argnum++] = "-noclear";
 
 	    switch (fmtproc) {
 	    case 1:
-		arglist[4] = "-fmtproc";
-		arglist[5] = formatproc;
-		arglist[6] = NULL;
+		arglist[argnum++] = "-fmtproc";
+		arglist[argnum++] = formatproc;
 		break;
 	    case 0:
-	    	arglist[4] = "-nofmtproc";
-		arglist[5] = NULL;
+	    	arglist[argnum++] = "-nofmtproc";
 		break;
-	    default:
-	    	arglist[4] = NULL;
 	    }
 
-	    execvp (mhlproc, arglist);
+	    arglist[argnum++] = NULL;
+
+	    execvp (mhl, arglist);
 	    errstr = strerror(errno);
 	    write(2, "unable to exec ", 15);
 	    write(2, mhlproc, strlen(mhlproc));