X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/b56c88e2847c582f9b18ae5bbda44f033cd49c42..63621a81d16ab743de6b57d47578a9a2c670ad22:/uip/rcvdist.c

diff --git a/uip/rcvdist.c b/uip/rcvdist.c
index a87a5e84..a75e21ac 100644
--- a/uip/rcvdist.c
+++ b/uip/rcvdist.c
@@ -1,6 +1,4 @@
-
-/*
- * rcvdist.c -- asynchronously redistribute messages
+/* rcvdist.c -- asynchronously redistribute messages
  *
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
@@ -13,6 +11,7 @@
 #include <h/tws.h>
 #include <h/mts.h>
 #include <h/utils.h>
+#include "sbr/m_mktemp.h"
 
 #define RCVDIST_SWITCHES \
     X("form formfile", 4, FORMSW) \
@@ -42,13 +41,13 @@ int
 main (int argc, char **argv)
 {
     pid_t child_id;
-    int i, vecp;
+    int vecp;
     char *addrs = NULL, *cp, *form = NULL, buf[BUFSIZ], *program;
     char **argp, **arguments, **vec;
     FILE *fp;
     char *tfile = NULL;
 
-    if (nmh_init(argv[0], 1)) { return 1; }
+    if (nmh_init(argv[0], 2)) { return 1; }
 
     done=unlink_done;
 
@@ -59,7 +58,7 @@ main (int argc, char **argv)
 
     vec = argsplit(postproc, &program, &vecp);
 
-    mts_init (invo_name);
+    mts_init ();
     arguments = getarguments (invo_name, argc, argv, 1);
     argp = arguments;
 
@@ -89,7 +88,7 @@ main (int argc, char **argv)
 		    continue;
 	    }
 	}
-	addrs = addrs ? add (cp, add (", ", addrs)) : getcpy (cp);
+	addrs = addrs ? add (cp, add (", ", addrs)) : mh_xstrdup(cp);
     }
 
     if (addrs == NULL)
@@ -118,18 +117,18 @@ main (int argc, char **argv)
 	done (1);
 
     vec[vecp++] = "-dist";
-    vec[vecp++] = drft;
     if ((cp = context_find ("mhlproc"))) {
       vec[vecp++] = "-mhlproc";
       vec[vecp++] = cp;
     }
+    vec[vecp++] = drft;
     vec[vecp] = NULL;
 
-    for (i = 0; (child_id = fork()) == NOTOK && i < 5; i++)
-	sleep (5);
+    child_id = fork();
     switch (child_id) {
 	case NOTOK: 
-	    admonish (NULL, "unable to fork");/* fall */
+	    inform("unable to fork, continuing...");
+	    /* FALLTHRU */
 	case OK: 
 	    execvp (program, vec);
 	    fprintf (stderr, "unable to exec ");
@@ -145,8 +144,6 @@ main (int argc, char **argv)
 
 /* very similar to routine in replsbr.c */
 
-#define	SBUFSIZ	256
-
 static int outputlinelen = OUTPUTLINELEN;
 
 static struct format *fmt;
@@ -173,12 +170,13 @@ static char *addrcomps[] = {
 static void
 rcvdistout (FILE *inb, char *form, char *addrs)
 {
-    register int char_read = 0, format_len, i, state;
-    register char **ap;
-    char *cp, *scanl, name[NAMESZ], tmpbuf[SBUFSIZ];
-    register struct comp *cptr;
+    int char_read = 0, format_len, i, state;
+    char **ap;
+    char *cp, name[NAMESZ], tmpbuf[NMH_BUFSIZ];
+    charstring_t scanl;
+    struct comp *cptr;
     FILE *out;
-    m_getfld_state_t gstate = 0;
+    m_getfld_state_t gstate;
 
     if (!(out = fopen (drft, "w")))
 	adios (drft, "unable to create");
@@ -198,25 +196,26 @@ rcvdistout (FILE *inb, char *form, char *addrs)
     if (cptr)
 	cptr->c_text = addrs;
 
+    gstate = m_getfld_state_init(inb);
     for (;;) {
-	int msg_count = SBUFSIZ;
-	switch (state = m_getfld (&gstate, name, tmpbuf, &msg_count, inb)) {
+	int msg_count = sizeof tmpbuf;
+	switch (state = m_getfld2(&gstate, name, tmpbuf, &msg_count)) {
 	    case FLD: 
 	    case FLDPLUS: 
 	    	i = fmt_addcomptext(name, tmpbuf);
 		if (i != -1) {
 		    char_read += msg_count;
 		    while (state == FLDPLUS) {
-			msg_count = SBUFSIZ;
-			state = m_getfld (&gstate, name, tmpbuf, &msg_count, inb);
+			msg_count = sizeof tmpbuf;
+			state = m_getfld2(&gstate, name, tmpbuf, &msg_count);
 			fmt_appendcomp(i, name, tmpbuf);
 			char_read += msg_count;
 		    }
 		}
 
 		while (state == FLDPLUS) {
-		    msg_count = SBUFSIZ;
-		    state = m_getfld (&gstate, name, tmpbuf, &msg_count, inb);
+		    msg_count = sizeof tmpbuf;
+		    state = m_getfld2(&gstate, name, tmpbuf, &msg_count);
 		}
 		break;
 
@@ -227,37 +226,37 @@ rcvdistout (FILE *inb, char *form, char *addrs)
 		goto finished;
 
 	    default: 
-		adios (NULL, "m_getfld() returned %d", state);
+		adios (NULL, "m_getfld2() returned %d", state);
 	}
     }
 finished: ;
     m_getfld_state_destroy (&gstate);
 
     i = format_len + char_read + 256;
-    scanl = mh_xmalloc ((size_t) i + 2);
+    scanl = charstring_create (i + 2);
     dat[0] = dat[1] = dat[2] = dat[4] = 0;
     dat[3] = outputlinelen;
-    fmt_scan (fmt, scanl, i + 1, i, dat, NULL);
-    fputs (scanl, out);
+    fmt_scan (fmt, scanl, i, dat, NULL);
+    fputs (charstring_buffer (scanl), out);
 
     if (ferror (out))
 	adios (drft, "error writing");
     fclose (out);
 
-    free (scanl);
+    charstring_free (scanl);
     fmt_free(fmt, 1);
 }
 
 
-static void
+static void NORETURN
 unlink_done (int status)
 {
     if (backup[0])
-	unlink (backup);
+	(void) m_unlink (backup);
     if (drft[0])
-	unlink (drft);
+	(void) m_unlink (drft);
     if (tmpfil[0])
-	unlink (tmpfil);
+	(void) m_unlink (tmpfil);
 
     exit (status ? RCV_MBX : RCV_MOK);
 }