X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/bacd74669e1b6614519259f7eaba98da54f9c97c..8c6e995a43e71e012ae133ff8ebea5719d9117fe:/sbr/showfile.c?ds=sidebyside

diff --git a/sbr/showfile.c b/sbr/showfile.c
index 369c953b..98b22df4 100644
--- a/sbr/showfile.c
+++ b/sbr/showfile.c
@@ -1,6 +1,4 @@
-
-/*
- * showfile.c -- invoke the `lproc' command
+/* showfile.c -- invoke the `lproc' command
  *
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
@@ -14,8 +12,9 @@ int
 showfile (char **arg, char *file)
 {
     pid_t pid;
-    int isdraft, vecp;
+    int vecp;
     char **vec, *program;
+    int retval = 1;
 
     context_save();	/* save the context file */
     fflush(stdout);
@@ -32,16 +31,16 @@ showfile (char **arg, char *file)
     case -1:
 	/* fork error */
 	advise ("fork", "unable to");
-	return 1;
+	break;
 
     case 0:
 	/* child */
 	vec = argsplit(lproc, &program, &vecp);
-	isdraft = 1;
+	bool isdraft = true;
 	if (arg) {
 	    while (*arg) {
 		if (**arg != '-')
-		    isdraft = 0;
+		    isdraft = false;
 		vec[vecp++] = *arg++;
 	    }
 	}
@@ -55,12 +54,12 @@ showfile (char **arg, char *file)
 	execvp (program, vec);
 	fprintf (stderr, "unable to exec ");
 	perror (lproc);
-	_exit (-1);
+	_exit(1);
 
     default:
 	/* parent */
-	return (pidwait (pid, -1) & 0377 ? 1 : 0);
+	retval = pidwait (pid, -1) & 0377 ? 1 : 0;
     }
 
-    return 1;	/* NOT REACHED */
+    return retval;
 }