X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/bf3160aa94f981374f0c6353344fd68a4e1daa12..9c7af92d3b8f712f62a69962f90d84a377424ed2:/uip/post.c

diff --git a/uip/post.c b/uip/post.c
index d981ff62..6dc18d10 100644
--- a/uip/post.c
+++ b/uip/post.c
@@ -290,7 +290,7 @@ static char *partno = NULL;
 static void putfmt (char *, char *, int *, FILE *);
 static void start_headers (void);
 static void finish_headers (FILE *);
-static int get_header (char *, struct headers *);
+static int get_header (char *, struct headers *) PURE;
 static int putadr (char *, char *, struct mailname *, FILE *, unsigned int,
 		   char *, unsigned int);
 static void putgrp (char *, char *, FILE *, unsigned int);
@@ -301,12 +301,12 @@ static int annoaux (struct mailname *);
 static void insert_fcc (struct headers *, char *);
 static void make_bcc_file (int);
 static void verify_all_addresses (int, int, char *, int, char *);
-static void chkadr (void);
+static void chkadr (void) PURE;
 static void sigon (void);
 static void sigoff (void);
 static void p_refile (char *);
 static void fcc (char *, char *);
-static void die (char *, char *, ...);
+static void fatal (char *, char *, ...) CHECK_PRINTF(2, 3);
 static void post (char *, int, int, int, char *, int, char *);
 static void do_text (char *file, int fd);
 static void do_an_address (struct mailname *, int);
@@ -584,8 +584,7 @@ main (int argc, char **argv)
 	}
 	if (msg)
 	    adios (NULL, "only one message at a time!");
-	else
-	    msg = cp;
+        msg = cp;
     }
 
     alias (AliasFile);
@@ -670,9 +669,8 @@ main (int argc, char **argv)
     if (debug) {
 	pl ();
 	done (0);
-    } else {
-	fclose (out);
     }
+    fclose (out);
 
     /*
      * Here's how we decide which address to use as the envelope-from
@@ -1608,12 +1606,12 @@ static void
 chkadr (void)
 {
     if (badadr && unkadr)
-	die (NULL, "%d address%s unparsable, %d addressee%s undeliverable",
+	fatal (NULL, "%d address%s unparsable, %d addressee%s undeliverable",
 		badadr, PLURALS(badadr), unkadr, PLURALS(badadr));
     if (badadr)
-	die (NULL, "%d address%s unparsable", badadr, PLURALS(badadr));
+	fatal (NULL, "%d address%s unparsable", badadr, PLURALS(badadr));
     if (unkadr)
-	die (NULL, "%d addressee%s undeliverable", unkadr, PLURALS(unkadr));
+	fatal (NULL, "%d addressee%s undeliverable", unkadr, PLURALS(unkadr));
 }
 
 
@@ -1654,7 +1652,7 @@ do_addresses (int bccque, int talk)
     chkadr ();
 
     if (rp_isbad (retval = sm_waend ()))
-	die (NULL, "problem ending addresses; %s", rp_string (retval));
+	fatal (NULL, "problem ending addresses; %s", rp_string (retval));
 }
 
 
@@ -1720,7 +1718,7 @@ post (char *file, int bccque, int talk, int eai, char *envelope,
         int eightbit = 0;
 
         if (fd == NOTOK) {
-          die (file, "unable to re-open");
+          fatal (file, "unable to re-open");
         }
 
         if (msgflags & MMIM  &&  cte != UNKNOWN) {
@@ -1730,7 +1728,7 @@ post (char *file, int bccque, int talk, int eai, char *envelope,
         } else {
             if (scan_input (fd, &eightbit) == NOTOK) {
                 close (fd);
-                die (file, "problem reading from");
+                fatal (file, "problem reading from");
             }
         }
 
@@ -1739,7 +1737,7 @@ post (char *file, int bccque, int talk, int eai, char *envelope,
 					oauth_flag ? auth_svc : NULL, tlsflag))
 		|| rp_isbad (retval = sm_winit (envelope, eai, eightbit))) {
 	    close (fd);
-	    die (NULL, "problem initializing server; %s", rp_string (retval));
+	    fatal (NULL, "problem initializing server; %s", rp_string (retval));
 	}
 
         do_addresses (bccque, talk && verbose);
@@ -1782,7 +1780,7 @@ verify_all_addresses (int talk, int eai, char *envelope, int oauth_flag,
 					verbose, snoop, sasl, saslmech, user,
 					oauth_flag ? auth_svc : NULL, tlsflag))
 		|| rp_isbad (retval = sm_winit (envelope, eai, eightbit))) {
-	    die (NULL, "problem initializing server; %s", rp_string (retval));
+	    fatal (NULL, "problem initializing server; %s", rp_string (retval));
 	}
     }
 
@@ -1872,7 +1870,7 @@ do_an_address (struct mailname *lp, int talk)
 	default: 
 	    if (!talk)
 		fprintf (stderr, "  %s: ", addr);
-	    die (NULL, "unexpected response; %s", rp_string (retval));
+	    fatal (NULL, "unexpected response; %s", rp_string (retval));
     }
 
     fflush (stdout);
@@ -1889,11 +1887,11 @@ do_text (char *file, int fd)
 
     while ((state = read (fd, buf, sizeof(buf))) > 0) {
 	if (rp_isbad (retval = sm_wtxt (buf, state)))
-	    die (NULL, "problem writing text; %s\n", rp_string (retval));
+	    fatal (NULL, "problem writing text; %s\n", rp_string (retval));
     }
 
     if (state == NOTOK)
-	die (file, "problem reading from");
+	fatal (file, "problem reading from");
 
     switch (retval = sm_wtend ()) {
 	case RP_OK: 
@@ -1901,11 +1899,11 @@ do_text (char *file, int fd)
 
 	case RP_NO: 
 	case RP_NDEL: 
-	    die (NULL, "posting failed; %s", rp_string (retval));
+	    fatal (NULL, "posting failed; %s", rp_string (retval));
 	    break;
 
 	default: 
-	    die (NULL, "unexpected response; %s", rp_string (retval));
+	    fatal (NULL, "unexpected response; %s", rp_string (retval));
     }
 }
 
@@ -2039,7 +2037,7 @@ fcc (char *file, char *folder)
  */
 
 static void
-die (char *what, char *fmt, ...)
+fatal (char *what, char *fmt, ...)
 {
     int err;
     va_list ap;