X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/d6b2ae5fa68b9a82ffc006c233aef64c5cdb3bd2..9291a5f82480f2458e04cb9ea7e6749bc952b308:/uip/sortm.c?ds=sidebyside

diff --git a/uip/sortm.c b/uip/sortm.c
index 0b8e1853..a9ce9854 100644
--- a/uip/sortm.c
+++ b/uip/sortm.c
@@ -1,15 +1,29 @@
-
-/*
- * sortm.c -- sort messages in a folder by date/time
+/* sortm.c -- sort messages in a folder by date/time
  *
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
  * complete copyright information.
  */
 
-#include <h/mh.h>
-#include <h/tws.h>
-#include <h/utils.h>
+#include "h/mh.h"
+#include "sbr/uprf.h"
+#include "sbr/m_convert.h"
+#include "sbr/getfolder.h"
+#include "sbr/ext_hook.h"
+#include "sbr/folder_read.h"
+#include "sbr/folder_free.h"
+#include "sbr/context_save.h"
+#include "sbr/context_replace.h"
+#include "sbr/context_find.h"
+#include "sbr/ambigsw.h"
+#include "sbr/path.h"
+#include "sbr/print_version.h"
+#include "sbr/print_help.h"
+#include "sbr/error.h"
+#include "h/tws.h"
+#include "h/done.h"
+#include "h/utils.h"
+#include "sbr/m_maildir.h"
 
 #define SORTM_SWITCHES \
     X("datefield field", 0, DATESW) \
@@ -44,10 +58,10 @@ struct smsg {
 static struct smsg *smsgs;
 int nmsgs;
 
-char *subjsort = (char *) 0;    /* sort on subject if != 0 */
+char *subjsort;                 /* sort on subject if != 0 */
 time_t datelimit = 0;
-int submajor = 0;		/* if true, sort on subject-major */
-int verbose;
+bool submajor;  		/* if true, sort on subject-major */
+bool verbose;
 int allmsgs = 1;
 int check_failed = 0;
 
@@ -76,9 +90,9 @@ main (int argc, char **argv)
     struct msgs_array msgs = { 0, 0, NULL };
     struct msgs *mp;
     struct smsg **dlist;
-    int checksw = 0;
+    bool checksw = false;
 
-    if (nmh_init(argv[0], 1)) { return 1; }
+    if (nmh_init(argv[0], true, true)) { return 1; }
 
     arguments = getarguments (invo_name, argc, argv, 1);
     argp = arguments;
@@ -93,7 +107,7 @@ main (int argc, char **argv)
 		ambigsw (cp, switches);
 		done (1);
 	    case UNKWNSW:
-		adios (NULL, "-%s unknown", cp);
+		die("-%s unknown", cp);
 
 	    case HELPSW:
 		snprintf(buf, sizeof(buf), "%s [+folder] [msgs] [switches]",
@@ -106,48 +120,48 @@ main (int argc, char **argv)
 
 	    case DATESW:
 		if (datesw)
-		    adios (NULL, "only one date field at a time");
+		    die("only one date field at a time");
 		if (!(datesw = *argp++) || *datesw == '-')
-		    adios (NULL, "missing argument to %s", argp[-2]);
+		    die("missing argument to %s", argp[-2]);
 		continue;
 
 	    case TEXTSW:
 		if (subjsort)
-		    adios (NULL, "only one text field at a time");
+		    die("only one text field at a time");
 		if (!(subjsort = *argp++) || *subjsort == '-')
-		    adios (NULL, "missing argument to %s", argp[-2]);
+		    die("missing argument to %s", argp[-2]);
 		continue;
 
 	    case SUBJSW:
 		subjsort = "subject";
 		continue;
 	    case NSUBJSW:
-		subjsort = (char *)0;
+		subjsort = NULL;
 		continue;
 
 	    case LIMSW:
 		if (!(cp = *argp++) || *cp == '-')
-			adios (NULL, "missing argument to %s", argp[-2]);
+			die("missing argument to %s", argp[-2]);
 		while (*cp == '0')
 		    cp++;		/* skip any leading zeros */
 		if (!*cp) {		/* hit end of string */
-		    submajor++;		/* sort subject-major */
+		    submajor = true;	/* sort subject-major */
 		    continue;
 		}
 		if (!isdigit((unsigned char) *cp) || !(datelimit = atoi(cp)))
-		    adios (NULL, "impossible limit %s", cp);
+		    die("impossible limit %s", cp);
 		datelimit *= 60*60*24;
 		continue;
 	    case NLIMSW:
-		submajor = 0;	/* use date-major, but */
-		datelimit = 0;	/* use no limit */
+		submajor = false;	/* use date-major, but */
+		datelimit = 0;	        /* use no limit */
 		continue;
 
 	    case VERBSW:
-		verbose++;
+		verbose = true;
 		continue;
 	    case NVERBSW:
-		verbose = 0;
+		verbose = false;
 		continue;
 
 	    case ALLMSGS:
@@ -158,20 +172,19 @@ main (int argc, char **argv)
 		continue;
 
 	    case CHECKSW:
-		checksw = 1;
+		checksw = true;
 		continue;
 	    case NCHECKSW:
-		checksw = 0;
+		checksw = false;
 		continue;
 	    }
 	}
 	if (*cp == '+' || *cp == '@') {
 	    if (folder)
-		adios (NULL, "only one folder at a time!");
-	    else
-		folder = pluspath (cp);
+		die("only one folder at a time!");
+            folder = pluspath (cp);
 	} else
-		app_msgarg(&msgs, cp);
+            app_msgarg(&msgs, cp);
     }
 
     if (!context_find ("path"))
@@ -180,7 +193,7 @@ main (int argc, char **argv)
 	if (allmsgs) {
 	    app_msgarg(&msgs, "all");
         } else {
-	    adios (NULL, "must specify messages to sort with -noall");
+	    die("must specify messages to sort with -noall");
         }
     }
     if (!datesw)
@@ -194,11 +207,11 @@ main (int argc, char **argv)
 
     /* read folder and create message structure */
     if (!(mp = folder_read (folder, 1)))
-	adios (NULL, "unable to read folder %s", folder);
+	die("unable to read folder %s", folder);
 
     /* check for empty folder */
     if (mp->nummsg == 0)
-	adios (NULL, "no messages in %s", folder);
+	die("no messages in %s", folder);
 
     /* parse all the message ranges/sequences and set SELECTED */
     for (msgnum = 0; msgnum < msgs.size; msgnum++)
@@ -207,16 +220,16 @@ main (int argc, char **argv)
     seq_setprev (mp);	/* set the previous sequence */
 
     if ((nmsgs = read_hdrs (mp, datesw)) <= 0)
-	adios (NULL, "no messages to sort");
+	die("no messages to sort");
 
     if (checksw  &&  check_failed) {
-	adios (NULL, "errors found, no messages sorted");
+	die("errors found, no messages sorted");
     }
 
     /*
      * sort a list of pointers to our "messages to be sorted".
      */
-    dlist = (struct smsg **) mh_xmalloc ((nmsgs+1) * sizeof(*dlist));
+    dlist = mh_xmalloc ((nmsgs+1) * sizeof(*dlist));
     for (i = 0; i < nmsgs; i++)
 	dlist[i] = &smsgs[i];
     dlist[nmsgs] = 0;
@@ -232,7 +245,7 @@ main (int argc, char **argv)
     }
 
     /* first sort by date, or by subject-major, date-minor */
-    qsort ((char *) dlist, nmsgs, sizeof(*dlist),
+    qsort (dlist, nmsgs, sizeof(*dlist),
 	    (qsort_comp) (submajor && subjsort ? txtsort : dsort));
 
     /*
@@ -242,30 +255,28 @@ main (int argc, char **argv)
      */
     if (!submajor && subjsort) {	/* already date sorted */
 	struct smsg **slist, **flist;
-	register struct smsg ***il, **fp, **dp;
+	struct smsg ***il, **fp, **dp;
 
-	slist = (struct smsg **) mh_xmalloc ((nmsgs+1) * sizeof(*slist));
-	memcpy((char *)slist, (char *)dlist, (nmsgs+1)*sizeof(*slist));
-	qsort((char *)slist, nmsgs, sizeof(*slist), (qsort_comp) subsort);
+	slist = mh_xmalloc ((nmsgs+1) * sizeof(*slist));
+	memcpy(slist, dlist, (nmsgs+1)*sizeof(*slist));
+	qsort(slist, nmsgs, sizeof(*slist), (qsort_comp) subsort);
 
 	/*
 	 * make an inversion list so we can quickly find
 	 * the collection of messages with the same subj
 	 * given a message number.
 	 */
-	il = (struct smsg ***) mh_xcalloc (mp->hghsel+1, sizeof(*il));
-	if (! il)
-	    adios (NULL, "couldn't allocate msg list");
+	il = mh_xcalloc(mp->hghsel + 1, sizeof *il);
 	for (i = 0; i < nmsgs; i++)
 	    il[slist[i]->s_msg] = &slist[i];
 	/*
 	 * make up the final list, chronological but with
 	 * all the same subjects grouped together.
 	 */
-	flist = (struct smsg **) mh_xmalloc ((nmsgs+1) * sizeof(*flist));
+	flist = mh_xmalloc ((nmsgs+1) * sizeof(*flist));
 	fp = flist;
 	for (dp = dlist; *dp;) {
-	    register struct smsg **s = il[(*dp++)->s_msg];
+	    struct smsg **s = il[(*dp++)->s_msg];
 
 	    /* see if we already did this guy */
 	    if (! s)
@@ -312,17 +323,9 @@ static int
 read_hdrs (struct msgs *mp, char *datesw)
 {
     int msgnum;
-    struct tws tb;
-    register struct smsg *s;
-
-    twscopy (&tb, dlocaltimenow ());
-
-    smsgs = (struct smsg *)
-	mh_xcalloc ((size_t) (mp->hghsel - mp->lowsel + 2),
-	    sizeof(*smsgs));
-    if (smsgs == NULL)
-	adios (NULL, "unable to allocate sort storage");
+    struct smsg *s;
 
+    smsgs = mh_xcalloc(mp->hghsel - mp->lowsel + 2, sizeof *smsgs);
     s = smsgs;
     for (msgnum = mp->lowsel; msgnum <= mp->hghsel; msgnum++) {
 	if (is_selected(mp, msgnum)) {
@@ -333,7 +336,7 @@ read_hdrs (struct msgs *mp, char *datesw)
 	}
     }
     s->s_msg = 0;
-    return(s - smsgs);
+    return s - smsgs;
 }
 
 
@@ -345,21 +348,22 @@ read_hdrs (struct msgs *mp, char *datesw)
 static int
 get_fields (char *datesw, int msg, struct smsg *smsg)
 {
-    register int state;
+    int state;
     int compnum;
-    char *msgnam, buf[BUFSIZ], nam[NAMESZ];
-    register struct tws *tw;
-    register char *datecomp = NULL, *subjcomp = NULL;
-    register FILE *in;
-    m_getfld_state_t gstate = 0;
+    char *msgnam, buf[NMH_BUFSIZ], nam[NAMESZ];
+    struct tws *tw;
+    char *datecomp = NULL, *subjcomp = NULL;
+    FILE *in;
+    m_getfld_state_t gstate;
 
     if ((in = fopen (msgnam = m_name (msg), "r")) == NULL) {
 	admonish (msgnam, "unable to read message");
-	return (0);
+	return 0;
     }
+    gstate = m_getfld_state_init(in);
     for (compnum = 1;;) {
 	int bufsz = sizeof buf;
-	switch (state = m_getfld (&gstate, nam, buf, &bufsz, in)) {
+	switch (state = m_getfld2(&gstate, nam, buf, &bufsz)) {
 	case FLD:
 	case FLDPLUS:
 	    compnum++;
@@ -367,7 +371,7 @@ get_fields (char *datesw, int msg, struct smsg *smsg)
 		datecomp = add (buf, datecomp);
 		while (state == FLDPLUS) {
 		    bufsz = sizeof buf;
-		    state = m_getfld (&gstate, nam, buf, &bufsz, in);
+		    state = m_getfld2(&gstate, nam, buf, &bufsz);
 		    datecomp = add (buf, datecomp);
 		}
 		if (!subjsort || subjcomp)
@@ -376,7 +380,7 @@ get_fields (char *datesw, int msg, struct smsg *smsg)
 		subjcomp = add (buf, subjcomp);
 		while (state == FLDPLUS) {
 		    bufsz = sizeof buf;
-		    state = m_getfld (&gstate, nam, buf, &bufsz, in);
+		    state = m_getfld2(&gstate, nam, buf, &bufsz);
 		    subjcomp = add (buf, subjcomp);
 		}
 		if (datecomp)
@@ -385,7 +389,7 @@ get_fields (char *datesw, int msg, struct smsg *smsg)
 		/* just flush this guy */
 		while (state == FLDPLUS) {
 		    bufsz = sizeof buf;
-		    state = m_getfld (&gstate, nam, buf, &bufsz, in);
+		    state = m_getfld2(&gstate, nam, buf, &bufsz);
 		}
 	    }
 	    continue;
@@ -397,19 +401,17 @@ get_fields (char *datesw, int msg, struct smsg *smsg)
 	case LENERR:
 	case FMTERR:
 	    if (state == LENERR || state == FMTERR) {
-		admonish (NULL, "format error in message %d (header #%d)",
+		inform("format error in message %d (header #%d), continuing...",
 		      msg, compnum);
 		check_failed = 1;
 	    }
-	    if (datecomp)
-		free (datecomp);
-	    if (subjcomp)
-		free (subjcomp);
+            free(datecomp);
+            free(subjcomp);
 	    fclose (in);
-	    return (0);
+	    return 0;
 
 	default:
-	    adios (NULL, "internal error -- you lose");
+	    die("internal error -- you lose");
 	}
 	break;
     }
@@ -422,10 +424,8 @@ get_fields (char *datesw, int msg, struct smsg *smsg)
     if (!datecomp || (tw = dparsetime (datecomp)) == NULL) {
 	struct stat st;
 
-	advise (NULL,
-		"can't parse %s field in message %d, "
-		"will use file modification time",
-		datesw, msg);
+	inform("can't parse %s field in message %d, "
+            "will use file modification time", datesw, msg);
 	fstat (fileno (in), &st);
 	smsg->s_clock = st.st_mtime;
 	check_failed = 1;
@@ -440,17 +440,16 @@ get_fields (char *datesw, int msg, struct smsg *smsg)
 	     * leading "re:", everything but letters & smash
 	     * letters to lower case.
 	     */
-	    register char  *cp, *cp2, c;
+	    char  *cp, *cp2, c;
 
 	    cp = subjcomp;
 	    cp2 = subjcomp;
 	    if (strcmp (subjsort, "subject") == 0) {
 		while ((c = *cp)) {
 		    if (! isspace((unsigned char) c)) {
-			if(uprf(cp, "re:"))
-			    cp += 2;
-			else
+			if(!uprf(cp, "re:"))
 			    break;
+                        cp += 2;
 		    }
 		    cp++;
 		}
@@ -458,8 +457,7 @@ get_fields (char *datesw, int msg, struct smsg *smsg)
 
 	    while ((c = *cp++)) {
 		if (isascii((unsigned char) c) && isalnum((unsigned char) c))
-		    *cp2++ = isupper((unsigned char) c) ?
-		    			tolower((unsigned char) c) : c;
+		    *cp2++ = tolower((unsigned char)c);
 	    }
 
 	    *cp2 = '\0';
@@ -470,10 +468,9 @@ get_fields (char *datesw, int msg, struct smsg *smsg)
 	smsg->s_subj = subjcomp;
     }
     fclose (in);
-    if (datecomp)
-	free (datecomp);
+    free(datecomp);
 
-    return (1);
+    return 1;
 }
 
 /*
@@ -483,13 +480,12 @@ static int
 dsort (struct smsg **a, struct smsg **b)
 {
     if ((*a)->s_clock < (*b)->s_clock)
-	return (-1);
-    else if ((*a)->s_clock > (*b)->s_clock)
-	return (1);
-    else if ((*a)->s_msg < (*b)->s_msg)
-	return (-1);
-    else
-	return (1);
+	return -1;
+    if ((*a)->s_clock > (*b)->s_clock)
+	return 1;
+    if ((*a)->s_msg < (*b)->s_msg)
+	return -1;
+    return 1;
 }
 
 /*
@@ -498,25 +494,24 @@ dsort (struct smsg **a, struct smsg **b)
 static int
 subsort (struct smsg **a, struct smsg **b)
 {
-    register int i;
+    int i;
 
     if ((i = strcmp ((*a)->s_subj, (*b)->s_subj)))
-	return (i);
+	return i;
 
-    return (dsort (a, b));
+    return dsort(a, b);
 }
 
 static int
 txtsort (struct smsg **a, struct smsg **b)
 {
-    register int i;
+    int i;
 
     if ((i = strcmp ((*a)->s_subj, (*b)->s_subj)))
-	return (i);
-    else if ((*a)->s_msg < (*b)->s_msg)
-	return (-1);
-    else
-	return (1);
+	return i;
+    if ((*a)->s_msg < (*b)->s_msg)
+	return -1;
+    return 1;
 }
 
 static void
@@ -528,7 +523,7 @@ rename_chain (struct msgs *mp, struct smsg **mlist, int msg, int endmsg)
 
     for (;;) {
 	nxt = mlist[msg] - smsgs;	/* mlist[msg] is a ptr into smsgs */
-	mlist[msg] = (struct smsg *)0;
+	mlist[msg] = NULL;
 	old = smsgs[nxt].s_msg;
 	new = smsgs[msg].s_msg;
 	strncpy (oldname, m_name (old), sizeof(oldname));
@@ -560,7 +555,7 @@ static void
 rename_msgs (struct msgs *mp, struct smsg **mlist)
 {
     int i, j, old, new;
-    bvector_t tmpset = bvector_create (0);
+    bvector_t tmpset = bvector_create ();
     char f1[BUFSIZ], tmpfil[BUFSIZ];
     char newbuf[PATH_MAX + 1];
     struct smsg *sp;
@@ -605,7 +600,7 @@ rename_msgs (struct msgs *mp, struct smsg **mlist)
 	rename_chain (mp, mlist, j, i);
 
 	/*
-	 *	Run the external hook to refile the temorary message number
+	 *	Run the external hook to refile the temporary message number
 	 *	to the real place.
 	 */