X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/ec18722d02bd307bd09f30715dc8ba4e1b8a6716..eae4e80fddb67ed353f32a54c9eeed1c1527e5a9:/uip/picksbr.c

diff --git a/uip/picksbr.c b/uip/picksbr.c
index 3f8a17c2..a5184799 100644
--- a/uip/picksbr.c
+++ b/uip/picksbr.c
@@ -116,7 +116,7 @@ static unsigned char cc[] = {
 #define	pinform		if (!talked++) inform
 
 struct nexus {
-    int (*n_action)();
+    int (*n_action)(struct nexus *n, FILE *fp, int msgnum, long start, long stop);
 
     union {
 	/* for {OR,AND,NOT}action */
@@ -180,7 +180,7 @@ static struct nexus *parse(void);
 static struct nexus *nexp1(void);
 static struct nexus *nexp2(void);
 static struct nexus *nexp3(void);
-static struct nexus *newnexus(int (*)(struct nexus *n,
+static struct nexus *newnexus(int (*action)(struct nexus *n,
     FILE *fp, int msgnum, long start, long stop));
 
 static int ORaction(struct nexus *n, FILE *fp, int msgnum,
@@ -519,8 +519,10 @@ PRaction (struct nexus *n, int level)
 		dasctime (&n->n_tws, TW_NULL));
 	return;
     }
-    fprintf (stderr, "UNKNOWN(0x%x)\n",
-	     (unsigned int)(unsigned long) (*n->n_action));
+
+    generic_pointer gp;
+    gp.f = (void (*)(void))n->n_action;
+    fprintf(stderr, "UNKNOWN(%p)\n", gp.v);
 }
 
 
@@ -794,7 +796,7 @@ advance (char *alp, char *aep)
 		do {
 		    lp--;
 		    if (advance ((char *) lp, (char *) ep))
-			return (1);
+			return 1;
 		} while (lp > curlp);
 		return 0;
 
@@ -813,14 +815,14 @@ cclass (unsigned char *aset, int ac, int af)
 
     set = aset;
     if ((c = ac) == 0)
-	return (0);
+	return 0;
 
     n = *set++;
     while (n--)
 	if (*set++ == c || set[-1] == cc[c])
-	    return (af);
+	    return af;
 
-    return (!af);
+    return !af;
 }
 
 
@@ -935,7 +937,7 @@ TWSaction(struct nexus *n, FILE *fp, int msgnum, long start, long stop)
 	switch (state = m_getfld2(&gstate, name, buf, &bufsz)) {
 	    case FLD: 
 	    case FLDPLUS: 
-                mh_xfree(bp);
+                free(bp);
 		bp = mh_xstrdup(buf);
 		while (state == FLDPLUS) {
 		    bufsz = sizeof buf;
@@ -952,11 +954,11 @@ TWSaction(struct nexus *n, FILE *fp, int msgnum, long start, long stop)
 	    case FMTERR: 
 		if (state == LENERR || state == FMTERR)
 		    inform("format error in message %d", msgnum);
-                mh_xfree(bp);
+                free(bp);
 		return 0;
 
 	    default: 
-		adios (NULL, "internal error -- you lose");
+		die("internal error -- you lose");
 	}
 	break;
     }
@@ -969,6 +971,6 @@ TWSaction(struct nexus *n, FILE *fp, int msgnum, long start, long stop)
 	state = n->n_after ? (twsort (tw, &n->n_tws) > 0)
 	    : (twsort (tw, &n->n_tws) < 0);
 
-    mh_xfree(bp);
+    free(bp);
     return state;
 }