X-Git-Url: https://diplodocus.org/git/nmh/blobdiff_plain/f29bbf35b2de1893a3e383943f813cbc4f41960b..b46d49ba:/uip/mhbuild.c?ds=inline

diff --git a/uip/mhbuild.c b/uip/mhbuild.c
index 87252a7c..b6f26eb9 100644
--- a/uip/mhbuild.c
+++ b/uip/mhbuild.c
@@ -1,6 +1,4 @@
-
-/*
- * mhbuild.c -- expand/translate MIME composition files
+/* mhbuild.c -- expand/translate MIME composition files
  *
  * This code is Copyright (c) 2002, by the authors of nmh.  See the
  * COPYRIGHT file in the root directory of the nmh distribution for
@@ -15,7 +13,12 @@
 #include <h/mime.h>
 #include <h/mhparse.h>
 #include <h/mhcachesbr.h>
+#include "h/done.h"
 #include <h/utils.h>
+#include "sbr/m_maildir.h"
+#include "sbr/m_mktemp.h"
+#include "mhfree.h"
+#include "mhoutsbr.h"
 
 #define MHBUILD_SWITCHES \
     X("auto", 0, AUTOSW) \
@@ -70,12 +73,6 @@ DEFINE_SWITCH_ENUM(MIMEENCODING);
 DEFINE_SWITCH_ARRAY(MIMEENCODING, encodingswitches);
 #undef X
 
-/* mhcachesbr.c */
-extern int rcachesw;
-extern int wcachesw;
-extern char *cache_public;
-extern char *cache_private;
-
 int debugsw = 0;
 
 int listsw   = 0;
@@ -86,16 +83,7 @@ int contentidsw = 1;
  * Temporary files
  */
 static char infile[BUFSIZ];
-static int unlink_infile  = 0;
-
 static char outfile[BUFSIZ];
-static int unlink_outfile = 0;
-
-static void unlink_done (int) NORETURN;
-
-/* mhbuildsbr.c */
-int output_message (CT, char *);
-int output_message_fp (CT, FILE *, char*);
 
 
 int
@@ -114,9 +102,7 @@ main (int argc, char **argv)
     int header_encoding = CE_UNKNOWN;
     size_t n;
 
-    if (nmh_init(argv[0], 1)) { return 1; }
-
-    done=unlink_done;
+    if (nmh_init(argv[0], 2)) { return 1; }
 
     arguments = getarguments (invo_name, argc, argv, 1);
     argp = arguments;
@@ -125,8 +111,7 @@ main (int argc, char **argv)
 	if (cp[0] == '-' && cp[1] == '\0') {
 	    if (compfile)
 		adios (NULL, "cannot specify both standard input and a file");
-	    else
-		compfile = cp;
+            compfile = cp;
 	    listsw = 0;		/* turn off -list if using standard in/out */
 	    verbosw = 0;	/* turn off -verbose listings */
 	    break;
@@ -169,9 +154,9 @@ main (int argc, char **argv)
 	    do_cache: ;
 		if (!(cp = *argp++) || *cp == '-')
 		    adios (NULL, "missing argument to %s", argp[-2]);
-		switch (*icachesw = smatch (cp, caches)) {
+		switch (*icachesw = smatch (cp, cache_policy)) {
 		case AMBIGSW:
-		    ambigsw (cp, caches);
+		    ambigsw (cp, cache_policy);
 		    done (1);
 		case UNKWNSW:
 		    adios (NULL, "%s unknown", cp);
@@ -290,8 +275,7 @@ main (int argc, char **argv)
 	}
 	if (compfile)
 	    adios (NULL, "only one composition file allowed");
-	else
-	    compfile = cp;
+        compfile = cp;
     }
 
     /*
@@ -299,7 +283,7 @@ main (int argc, char **argv)
      */
     if ((cp = getenv ("MHBUILD"))) {
 	if ((fp = fopen (cp, "r"))) {
-	    readconfig ((struct node **) 0, fp, cp, 0);
+	    readconfig(NULL, fp, cp, 0);
 	    fclose (fp);
 	} else {
 	    admonish ("", "unable to read $MHBUILD profile (%s)", cp);
@@ -310,7 +294,7 @@ main (int argc, char **argv)
      * Read the standard profile setup
      */
     if ((fp = fopen (cp = etcpath ("mhn.defaults"), "r"))) {
-	readconfig ((struct node **) 0, fp, cp, 0);
+	readconfig(NULL, fp, cp, 0);
 	fclose (fp);
     }
 
@@ -338,10 +322,7 @@ main (int argc, char **argv)
 	    adios(NULL, "unable to create temporary file in %s",
 		  get_temp_dir());
 	}
-
-	/* save a copy of the name for later removal */
 	strncpy (infile, cp, sizeof(infile));
-	unlink_infile = 1;
 
 	/* copy standard input to temporary file */
 	while ((n = fread(buffer, 1, sizeof(buffer), stdin)) > 0) {
@@ -399,10 +380,9 @@ main (int argc, char **argv)
 
     /* output MIME message to this temporary file */
     if ((cp = m_mktemp2(compfile, invo_name, NULL, &fp_out)) == NULL) {
-	adios(NULL, "unable to create temporary file in %s", get_temp_dir());
+	adios(NULL, "unable to create temporary file");
     }
     strncpy(outfile, cp, sizeof(outfile));
-    unlink_outfile = 1;
 
     /* output the message */
     output_message_fp (ct, fp_out, outfile);
@@ -426,25 +406,12 @@ main (int argc, char **argv)
 	rename (buffer, compfile);
 	done (1);
     }
-    unlink_outfile = 0;
+    /* Remove from atexit(3) list of files to unlink. */
+    if (!(m_unlink(outfile) == -1 && errno == ENOENT)) {
+        adios(outfile, "file exists after rename:");
+    }
 
     free_content (ct);
     done (0);
     return 1;
 }
-
-
-static void
-unlink_done (int status)
-{
-    /*
-     * Check if we need to remove stray
-     * temporary files.
-     */
-    if (unlink_infile)
-	(void) m_unlink (infile);
-    if (unlink_outfile)
-	(void) m_unlink (outfile);
-
-    exit (status);
-}