]> diplodocus.org Git - nmh/commitdiff
Document advise(), adios(), admonish(), and advertise().
authorRalph Corderoy <ralph@inputplus.co.uk>
Sat, 22 Oct 2016 13:43:11 +0000 (14:43 +0100)
committerRalph Corderoy <ralph@inputplus.co.uk>
Sat, 22 Oct 2016 13:43:11 +0000 (14:43 +0100)
It doesn't make their design any better.  Their "ad" prefix goes against
common advice of having distinguishable identifiers to avoid mix-ups,
and seems to be a theme that got out of hand.  The out-of-order
parameters to advertise seem due to lack of strerror(3) that's no longer
a problem.

Before:
    advertise("open", "continuing...", "couldn't read profile: %s",
        path);
Could be:
    error("couldn't read profile: %s: open: %s, continuing...\n",
        path, strerror(errno));
And the "open" is typically dropped as superfluous so there's a
repetitive leading NULL passed a lot.


No differences found