Fix unlikely bug in oauth's make_query_url() of base_url overflow.

diff --git a/sbr/oauth.c b/sbr/oauth.c
index f195e6fe45934b47e3cfde576d05ea4c27cb0e63..7977586cd25970c4414d49e3541220f90472d988 100755 (executable)
--- a/sbr/oauth.c
+++ b/sbr/oauth.c
@@ -840,7 +840,10 @@ make_query_url(char *s, size_t size, CURL *curl, const char *base_url, ...)
         len = 0;
         prefix = "";
     } else {
         len = 0;
         prefix = "";
     } else {

-        len = sprintf(s, "%s", base_url);
+        len = strlen(base_url);
+        if (len > size - 1) /* Less one for NUL. */
+            return FALSE;
+        strcpy(s, base_url);

         prefix = "?";
     }
 
         prefix = "?";
     }