Compare character with EOF using signed comparison because

EOF can be (and is likely) negative.  This showed up on
arm7, which apparently uses unsigned char for char.

diff --git a/sbr/m_getfld.c b/sbr/m_getfld.c
index d278e5288828917ca1f48e1259f2d5c68c59155b..63b3fda21fd87713a60f4c2a34ff331e329d8923 100644 (file)
--- a/sbr/m_getfld.c
+++ b/sbr/m_getfld.c
@@ -799,7 +799,7 @@ m_unknown(m_getfld_state_t *gstate, FILE *iob)
     s->msg_style = MS_UNKNOWN;
 
     for (i = 0, cp = text; i < sizeof text; ++i, ++cp) {
     s->msg_style = MS_UNKNOWN;
 
     for (i = 0, cp = text; i < sizeof text; ++i, ++cp) {

-       if ((*cp = Getc (s)) == EOF) {
+       if ((signed char) (*cp = Getc (s)) == EOF) {

            break;
        }
     }
            break;
        }
     }


@@ -879,7 +879,7 @@ m_Eom (m_getfld_state_t s, int c)
     char *cp;
 
     for (i = 0, cp = text; i < s->edelimlen; ++i, ++cp) {
     char *cp;
 
     for (i = 0, cp = text; i < s->edelimlen; ++i, ++cp) {

-       if ((*cp = Getc (s)) == EOF) {
+       if ((signed char) (*cp = Getc (s)) == EOF) {

            break;
        }
     }
            break;
        }
     }