From: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed, 23 Aug 2017 20:39:59 +0000 (+0100)
Subject: sh scripts: Remove `else' after exit at end of then-block.
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/000facfea7a1335c17a7ffb9ff520ea3873f3745?hp=a129ed9494a4958069d0d74d18e9211b8cb139f2

sh scripts: Remove `else' after exit at end of then-block.

Only for simple if-then-else-fi with no elif.
---

diff --git a/test/rcv/test-rcvstore b/test/rcv/test-rcvstore
index 6337b893..48bf8c1b 100755
--- a/test/rcv/test-rcvstore
+++ b/test/rcv/test-rcvstore
@@ -183,12 +183,10 @@ if [ "`find ${MH_TEST_DIR}/Mail/test-read-perms -perm 600`"x = ''x ]; then
   if [ ${failed:-0} -eq 0 ]; then
     echo "$Test $0 SKIP (cannot remove read permission on plain files)"
     exit 77
-  else
-    exit $failed
   fi
-else
-  rm -f ${MH_TEST_DIR}/Mail/test-read-perms
+  exit $failed
 fi
+rm -f ${MH_TEST_DIR}/Mail/test-read-perms
 
 # check default Msg-Protect
 msgprot=`mhparam msgprot`
diff --git a/uip/mhmail b/uip/mhmail
index 09625afc..b94886f0 100755
--- a/uip/mhmail
+++ b/uip/mhmail
@@ -299,10 +299,9 @@ else
 
   if "$post_or_send" $postsendargs "$tmpfile"; then
     exit
-  else
-    status=$?
-    mv -f "$tmpfile" dead.letter
-    printf 'Letter saved in dead.letter\n' >&2
-    exit $status
   fi
+  status=$?
+  mv -f "$tmpfile" dead.letter
+  printf 'Letter saved in dead.letter\n' >&2
+  exit $status
 fi