From: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri, 21 Oct 2016 20:14:24 +0000 (+0100)
Subject: Explain isascii() test more in netsec_set_sasl_params().
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/12cecf3365e054bea3752bab57c0b1ecbf4f4dbb?hp=ac95517a622081f0f4625dbdbad283b54ab56300

Explain isascii() test more in netsec_set_sasl_params().

It stops non-ASCII lower in the SASL mechanism being uppered, just in
case there is some.
---

diff --git a/sbr/netsec.c b/sbr/netsec.c
index 8a0bba66..8259704e 100644
--- a/sbr/netsec.c
+++ b/sbr/netsec.c
@@ -1023,7 +1023,7 @@ netsec_set_sasl_params(netsec_context *nsc, const char *hostname,
 	nsc->sasl_mech = mh_xstrdup(mechanism);
 
 	for (p = nsc->sasl_mech; *p; p++)
-	    if (isascii((unsigned char) *p))	/* Just in case */
+	    if (isascii((unsigned char) *p)) /* Leave non-ASCII lower alone. */
 		*p = toupper((unsigned char) *p);
     }