From: Ralph Corderoy Date: Sat, 9 Sep 2017 17:28:31 +0000 (+0100) Subject: folder_pack.c: Flip if-condition so return moves from else block. X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/2e150215834904311e167edb9eefac4aee023fc5?ds=inline folder_pack.c: Flip if-condition so return moves from else block. Then no need for else block after return. --- diff --git a/sbr/folder_pack.c b/sbr/folder_pack.c index 82a366c8..22c02079 100644 --- a/sbr/folder_pack.c +++ b/sbr/folder_pack.c @@ -33,12 +33,11 @@ folder_pack (struct msgs **mpp, int verbose) * for all numbers from 1 to current high message. */ if (mp->lowoff > 1) { - if ((mp = folder_realloc (mp, 1, mp->hghmsg))) - *mpp = mp; - else { + if (!(mp = folder_realloc(mp, 1, mp->hghmsg))) { inform("unable to allocate folder storage"); return -1; } + *mpp = mp; } for (msgnum = mp->lowmsg, hole = 1; msgnum <= mp->hghmsg; msgnum++) {