From: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon, 17 Apr 2017 10:13:36 +0000 (+0100)
Subject: Don't store getname()'s return value during flushing.
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/3e3e0f988322e6cec76a78a4cdf68bd158d552e6?ds=inline

Don't store getname()'s return value during flushing.

`cp' after the loop is overwritten before being read.
Not storing the return value makes it clear it's not used.
---

diff --git a/sbr/addrsbr.c b/sbr/addrsbr.c
index 86b18a14..5ad8769e 100644
--- a/sbr/addrsbr.c
+++ b/sbr/addrsbr.c
@@ -310,12 +310,9 @@ ismymbox (struct mailname *np)
 		return 0;
 	    }
 
-	    /*
-	     * Sigh, it turns out that the address parser gets messed up
-	     * if you don't call getname() until it returns NULL.
-	     */
-
-	    while ((cp = getname(am)) != NULL)
+	    /* Sigh, it turns out that the address parser gets messed up
+	     * if you don't call getname() until it returns NULL. */
+	    while (getname(am) != NULL)
 	    	;
 	}