From: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu, 20 Oct 2016 22:57:56 +0000 (+0100)
Subject: Don't `else' after return.  Simplify control flow.
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/4e8294e08d172bb1db6b5bcc8c00e259cd0bb6ca?ds=sidebyside;hp=c559ac800555d0ab0bd236e9ea938f3b96703379

Don't `else' after return.  Simplify control flow.
---

diff --git a/uip/popsbr.c b/uip/popsbr.c
index 50cdf09b..fa9b99d1 100644
--- a/uip/popsbr.c
+++ b/uip/popsbr.c
@@ -252,21 +252,20 @@ pop_init (char *host, char *port, char *user, char *proxy, int snoop,
 			return NOTOK;
 		    }
 		    return OK;
-		} else {
-		    nmh_creds_t creds;
-
-		    if (!(creds = nmh_get_credentials(host, user)))
-			return NOTOK;
-		    if (command ("USER %s", nmh_cred_get_user(creds))
-		    						!= NOTOK) {
-			if (command("PASS %s", nmh_cred_get_password(creds))
-								!= NOTOK) {
-			    nmh_credentials_free(creds);
-			    return OK;
-			}
-		    }
-		    nmh_credentials_free(creds);
 		}
+                nmh_creds_t creds;
+
+                if (!(creds = nmh_get_credentials(host, user)))
+                    return NOTOK;
+                if (command ("USER %s", nmh_cred_get_user(creds))
+                                                            != NOTOK) {
+                    if (command("PASS %s", nmh_cred_get_password(creds))
+                                                            != NOTOK) {
+                        nmh_credentials_free(creds);
+                        return OK;
+                    }
+                }
+                nmh_credentials_free(creds);
 	    }
 	    strncpy (buffer, response, sizeof(buffer));
 	    command ("QUIT");
@@ -693,8 +692,7 @@ multiline (void)
     if (strncmp (buffer, TRM, TRMLEN) == 0) {
 	if (buffer[TRMLEN] == 0)
 	    return DONE;
-	else
-	    strncpy (response, buffer + TRMLEN, sizeof(response));
+        strncpy (response, buffer + TRMLEN, sizeof(response));
     }
     else
 	strncpy (response, buffer, sizeof(response));