From: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun, 10 Sep 2017 10:35:20 +0000 (+0100)
Subject: pidstatus(): Delete commented-out code testing for exit(255).
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/87751a2f760b5b1bd93f78120bfcc54a54b2c074?ds=inline

pidstatus(): Delete commented-out code testing for exit(255).

Pre-dating git, a test of wait(2)'s status having its top eight bits all
set was commented out an "I've no idea what this does" explanation.  The
top eight bits hold either exit(3)'s parameter or the signal that caused
the child to stop.  Either way, there are macros for pulling apart that
value and they're being used.  Perhaps they were broken on a much older
system.  Delete the comment, including its code.
---

diff --git a/sbr/pidstatus.c b/sbr/pidstatus.c
index d11a37e4..f8a37f39 100644
--- a/sbr/pidstatus.c
+++ b/sbr/pidstatus.c
@@ -29,14 +29,6 @@ pidstatus (int status, FILE *fp, char *cp)
     int signum;
     char *signame;
 
-/*
- * I have no idea what this is for (rc)
- * so I'm commenting it out for right now.
- *
- *  if ((status & 0xff00) == 0xff00)
- *      return status;
- */
-
     /* If child process returned normally */
     if (WIFEXITED(status)) {
 	if ((signum = WEXITSTATUS(status))) {