From: Ken Hornstein <kenh@pobox.com>
Date: Thu, 22 Sep 2016 23:12:12 +0000 (-0400)
Subject: Add error reporting for one case, and move around the return code
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/984c278593ba8b52cc30caf8d8dfaf184f3c5b4c?ds=inline;hp=-c

Add error reporting for one case, and move around the return code
in the SASL callback a bit.
---

984c278593ba8b52cc30caf8d8dfaf184f3c5b4c
diff --git a/uip/popsbr.c b/uip/popsbr.c
index 70d71044..9e394287 100644
--- a/uip/popsbr.c
+++ b/uip/popsbr.c
@@ -384,8 +384,10 @@ pop_sasl_callback(enum sasl_message_type mtype, unsigned const char *indata,
 	} else {
 	    rc = decodeBase64(line + 2, (const char **) outdata, &len, 0, NULL);
 	    *outdatalen = len;
-	    if (rc != OK)
+	    if (rc != OK) {
+		netsec_err(errstr, "Unable to decode base64 response");
 		return NOTOK;
+	    }
 	}
 	break;
 
@@ -411,8 +413,6 @@ pop_sasl_callback(enum sasl_message_type mtype, unsigned const char *indata,
 
 	if (netsec_flush(nsc, errstr) != OK)
 	    return NOTOK;
-
-	return OK;
 	break;
 
     /*
@@ -447,7 +447,8 @@ pop_sasl_callback(enum sasl_message_type mtype, unsigned const char *indata,
 	    return NOTOK;
 	break;
     }
-return OK;
+
+    return OK;
 }
 
 /*