From: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed, 19 Oct 2016 23:43:52 +0000 (+0100)
Subject: Hoist test of search string for NULL out of loop.
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/b1722537108cceec472480a551b9a7fb9c660c55?ds=sidebyside

Hoist test of search string for NULL out of loop.
---

diff --git a/uip/mhparam.c b/uip/mhparam.c
index bf0dfae7..55ac3c31 100644
--- a/uip/mhparam.c
+++ b/uip/mhparam.c
@@ -265,8 +265,10 @@ p_find(char *str)
 {
     struct proc *ps;
 
+    if (!str)
+        str = "";
     for (ps = procs; ps->p_name; ps++)
-	if (!strcasecmp (ps->p_name, str ? str : ""))
+	if (!strcasecmp (ps->p_name, str))
 	    return (*ps->p_field);
 
     return NULL;