From: David Levine <levinedl@acm.org>
Date: Fri, 25 Nov 2016 14:02:08 +0000 (-0500)
Subject: Close temp file.
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/c1e7215519ea50d95fc30d0a8064db6633a7d559?ds=sidebyside;hp=f877b4ce909e65e97cf9259b7113078b93587653

Close temp file.
---

diff --git a/uip/mhfixmsg.c b/uip/mhfixmsg.c
index 299d24a2..ff3e383a 100644
--- a/uip/mhfixmsg.c
+++ b/uip/mhfixmsg.c
@@ -547,6 +547,7 @@ mhfixmsgsbr (CT *ctp, char *maildir, const fix_transformations *fx,
 
         if ((*ctp)->c_file) {
             char *tempfile;
+            /* outfp will be closed by the caller */
             if ((tempfile = m_mktemp2 (NULL, invo_name, NULL, outfp)) ==
                 NULL) {
                 adios (NULL, "unable to create temporary file in %s",
@@ -1489,6 +1490,7 @@ build_text_plain_part (CT encoded_part) {
            be unlinked by free_content (). */
         char *tempfile;
 
+        /* This m_mktemp2() call closes the temp file. */
         if ((tempfile = m_mktemp2 (NULL, invo_name, NULL, NULL)) == NULL) {
             advise (NULL, "unable to create temporary file in %s",
                     get_temp_dir());
@@ -1627,6 +1629,9 @@ decode_part (CT ct) {
     status = output_message_fp (ct, file, tmp_decoded);
     (void) m_unlink (tmp_decoded);
     free (tmp_decoded);
+    if (fclose (file)) {
+        admonish (NULL, "unable to close temporary file %s", tempfile);
+    }
 
     return status;
 }