From: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon, 24 Oct 2016 17:59:30 +0000 (+0100)
Subject: netsec_set_tls(): Return a value in the !TLS_SUPPORT && !tls case.
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/c21f32c1daf73cf300a4b698582aee15da48fe2a?ds=sidebyside

netsec_set_tls(): Return a value in the !TLS_SUPPORT && !tls case.

Silences clang.
---

diff --git a/sbr/netsec.c b/sbr/netsec.c
index c07371ac..7972d1fa 100644
--- a/sbr/netsec.c
+++ b/sbr/netsec.c
@@ -1422,8 +1422,8 @@ netsec_set_oauth_service(netsec_context *nsc, const char *service)
 int
 netsec_set_tls(netsec_context *nsc, int tls, char **errstr)
 {
-    if (tls) {
 #ifdef TLS_SUPPORT
+    if (tls) {
 	SSL *ssl;
 	BIO *rbio, *wbio, *ssl_bio;;
 
@@ -1529,13 +1529,14 @@ netsec_set_tls(netsec_context *nsc, int tls, char **errstr)
     BIO_free_all(nsc->ssl_io);
     nsc->ssl_io = NULL;
 
-    return OK;
 #else /* TLS_SUPPORT */
+    if (tls) {
 	netsec_err(errstr, "TLS is not supported");
-
 	return NOTOK;
     }
 #endif /* TLS_SUPPORT */
+
+    return OK;
 }
 
 /*