From: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu, 20 Oct 2016 22:57:09 +0000 (+0100)
Subject: Don't `else' after return.  Simplify control flow.
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/c559ac800555d0ab0bd236e9ea938f3b96703379?hp=4aace27b5eeab890bdab8e1e1725b02ab435ff6a

Don't `else' after return.  Simplify control flow.
---

diff --git a/sbr/utils.c b/sbr/utils.c
index fff1aacd..fbada4e6 100644
--- a/sbr/utils.c
+++ b/sbr/utils.c
@@ -481,15 +481,14 @@ nmh_version_changed (int older) {
         }
 
         return old_version < current_version  ?  1  :  0;
-    } else {
-        if (context_version == NULL  ||  strcmp(context_version, "nmh-" VERSION) != 0) {
-            context_replace ("Version", "nmh-" VERSION);
+    }
 
-            return 1;
-        } else {
-            return 0;
-        }
+    if (context_version == NULL  ||  strcmp(context_version, "nmh-" VERSION) != 0) {
+        context_replace ("Version", "nmh-" VERSION);
+        return 1;
     }
+
+    return 0;
 }