From: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun, 10 Sep 2017 14:11:18 +0000 (+0100)
Subject: find_cache(): Remove test that's always false.
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/d247f1cf67f3e579ccddfa986c603dd91880cbe7?ds=sidebyside;hp=544d453bef5ccf734140f36efb1efd08ab8d71cb

find_cache(): Remove test that's always false.

The if-statement's condition is a conjunctive that tests `!writing' and
then, only if that's true, calls find_cache_aux() and tests `writing' in
determining the first argument;  that must be false.  Bug pre-dates git
history.
---

diff --git a/uip/mhcachesbr.c b/uip/mhcachesbr.c
index 9b410e22..b740e231 100644
--- a/uip/mhcachesbr.c
+++ b/uip/mhcachesbr.c
@@ -181,7 +181,7 @@ find_cache (CT ct, int policy, int *writing, char *id,
 	case CACHE_PUBLIC:
 	    if (cache_private
 		    && !writing
-		    && find_cache_aux (writing ? 2 : 0, cache_private, id,
+		    && find_cache_aux (0, cache_private, id,
 				       buffer, buflen) == OK) {
 		if (access (buffer, R_OK) != NOTOK) {
 got_private: