From: David Levine <levinedl@acm.org>
Date: Sat, 15 Mar 2014 00:04:45 +0000 (-0500)
Subject: Compare character with EOF using signed comparison because
X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/d2520ac7054ad75d60342606bf13c821305d958c?hp=b73185efc787e834b423b1f6d3a44e5ed6a54df5

Compare character with EOF using signed comparison because
EOF can be (and is likely) negative.  This showed up on
arm7, which apparently uses unsigned char for char.
---

diff --git a/sbr/m_getfld.c b/sbr/m_getfld.c
index d278e528..63b3fda2 100644
--- a/sbr/m_getfld.c
+++ b/sbr/m_getfld.c
@@ -799,7 +799,7 @@ m_unknown(m_getfld_state_t *gstate, FILE *iob)
     s->msg_style = MS_UNKNOWN;
 
     for (i = 0, cp = text; i < sizeof text; ++i, ++cp) {
-	if ((*cp = Getc (s)) == EOF) {
+	if ((signed char) (*cp = Getc (s)) == EOF) {
 	    break;
 	}
     }
@@ -879,7 +879,7 @@ m_Eom (m_getfld_state_t s, int c)
     char *cp;
 
     for (i = 0, cp = text; i < s->edelimlen; ++i, ++cp) {
-	if ((*cp = Getc (s)) == EOF) {
+	if ((signed char) (*cp = Getc (s)) == EOF) {
 	    break;
 	}
     }