From: Ralph Corderoy Date: Sat, 23 Sep 2017 13:14:12 +0000 (+0100) Subject: mhshow/test-charset: printf(1)'s octal doesn't need a leading zero. X-Git-Url: https://diplodocus.org/git/nmh/commitdiff_plain/e88901284d9f76832b619ec0b7281f1163154588?hp=90edf2e26c34b9ee225cb066eed069b9b7394c43 mhshow/test-charset: printf(1)'s octal doesn't need a leading zero. The `\0344' was being interpreted as `\034' and `4'. This can still be converted from EBCDIC-US to UTF-8 by iconv(1) so the test worked, but it was misleading. Remove the leading zero as printf's octal escape is `\nnn' where nnn is one to three octal digits. It's echo(1) that insists on a leading zero. Fixes 6fd1d18f. --- diff --git a/test/mhshow/test-charset b/test/mhshow/test-charset index 5414c9a9..72aeb79e 100755 --- a/test/mhshow/test-charset +++ b/test/mhshow/test-charset @@ -29,7 +29,7 @@ else #### FreeBSD10 buildbot. It doesn't support EBCDIC-US, which is used #### by the checks, so check for that. Though that doesn't seem to be #### the reason. - printf '\0344' | iconv -f EBCDIC-US -t UTF-8 >/dev/null 2>&1 || + printf '\344' | iconv -f EBCDIC-US -t UTF-8 >/dev/null 2>&1 || skip_param_value_checks=1 fi